Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude folders under webapp from ui5 build process #124

Closed
2 of 6 tasks
rednose84 opened this issue Jan 22, 2019 · 8 comments · Fixed by SAP/ui5-builder#254
Closed
2 of 6 tasks

Exclude folders under webapp from ui5 build process #124

rednose84 opened this issue Jan 22, 2019 · 8 comments · Fixed by SAP/ui5-builder#254
Assignees
Labels
enhancement New feature or request

Comments

@rednose84
Copy link

Expected Behavior

With UI5 build I want to exclude folders from build process.

Current Behavior

folder structure something like this
├──webapp
| ├──controller
| ├──view
| ├──test
| ├──test_screenshots
| ├──test_cases

If i run ui5 build all folders which are included in webapp are "uglified" (and something else) and copied to the dist (output) folder.

It it may be usefull to exclude certain folders from that proccess.

Affected components (if known)

@RandomByte RandomByte added the enhancement New feature or request label Jan 22, 2019
@vin-chen
Copy link

is there's any roadmap/plan for this?

@cschuff
Copy link

cschuff commented Feb 22, 2019

I think this is essential since even some standard SAP Web IDE templates contain folders like localService within webapp.

@RandomByte
Copy link
Member

If there would be an option to exclude resources, would you expect an excluded resource to be ignored by the UI5 Builder but still to be available in the UI5 Server? Or should it be excluded from both?

@vin-chen
Copy link

I'd prefer both.

Since I want to exclude it from the building process, it means I don't want to see it in the generated folder/files. Thus, it will not available in UI5 server too.

@BenReim
Copy link

BenReim commented Mar 12, 2019

I could actually imagine use cases where it would make sense to exclude folders from the build process, yet still have them available through the ui5-server.

For instance, think of test-resources which a developer would want to leverage during development time, yet might not want them to be included in a build result.

@RandomByte
Copy link
Member

So two configuration options it is 😄

One general exclude and one builder specific.

Thank you for your feedback.

@RandomByte
Copy link
Member

RandomByte commented Jun 3, 2019

The builder specific exclude has been implemented with SAP/ui5-builder#254 and related PRs.

Documentation is still pending but the feature can already be tested with UI5 CLI version 1.5.0 as described here:
https://github.com/SAP/ui5-project/pull/180/files?short_path=7b182d5#diff-7b182d5ba2fea830f66aca8de9366067

Feedback is highly appreciated!

@rednose84 I think this resolves your issue, hence I'll close it.

For the general exclude option that I proposed during the discussion I have created a new issue #155. Please leave feedback there it you want to see that implemented as well!

@RandomByte
Copy link
Member

Now documented in master 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants