-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Builder: Add excludes option #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
static-excludes
branch
from
May 23, 2019 13:42
cbb4b80
to
925909f
Compare
Instead of deprecated useNamespace flag. Also see SAP/ui5-fs@56b85e9
Wrap in addition "resources" configuration object
matz3
reviewed
May 29, 2019
devtomtom
approved these changes
Jun 3, 2019
RandomByte
changed the title
[FEATURE] builder: Add excludes option
[FEATURE] Builder: Add excludes option
Jun 3, 2019
6 tasks
nlunets
pushed a commit
to nlunets/ui5-builder
that referenced
this pull request
Jun 11, 2019
* Builder: Provide getProjectExcludes callback to resourceFactory * Adapt tests to new behavior of FileSystem._runGlob which now throws for GLOB errors * Add builder integration test for file exclude patterns * Use new resourceFactory API parameter "getVirtualBasePathPrefix" * Instead of deprecated useNamespace flag. Also see SAP/ui5-fs@56b85e9 * Update globby dependency * Bump @ui5/fs from 1.0.2 to 1.1.0 (Changelog of this version: https://github.com/SAP/ui5-fs/blob/v1.1.0/CHANGELOG.md)
devtomtom
pushed a commit
that referenced
this pull request
Jun 17, 2019
* Builder: Provide getProjectExcludes callback to resourceFactory * Adapt tests to new behavior of FileSystem._runGlob which now throws for GLOB errors * Add builder integration test for file exclude patterns * Use new resourceFactory API parameter "getVirtualBasePathPrefix" * Instead of deprecated useNamespace flag. Also see SAP/ui5-fs@56b85e9 * Update globby dependency * Bump @ui5/fs from 1.0.2 to 1.1.0 (Changelog of this version: https://github.com/SAP/ui5-fs/blob/v1.1.0/CHANGELOG.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on SAP/ui5-fs#140
Partially resolves SAP/ui5-tooling#124
Documentation: SAP/ui5-project#180