[RFC] 00010 UI5 Builder-Bundling Refactoring #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…code at the end of a bundle
Similar to Array.filter
RandomByte
force-pushed
the
rfc-ui5-builder-bundling-refactoring
branch
from
b1ed587 to
6c6f066
Compare
|
|
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Feb 23, 2022
Resolves SAP/ui5-tooling#472 Supersedes #282 Based on SAP/ui5-tooling#583 JIRA: CPOUI5FOUNDATION-434 Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
codeworrior
reviewed
Mar 22, 2022
| @@ -158,8 +158,6 @@ To be discussed. | |||
| ## Unresolved Questions and Bikeshedding | |||
| *This section should be removed (i.e. resolved) before merging* | |||
|
|
|||
| Should we generate source maps during bundling if none is provided for a resource? This could be a simple mapping of only the first column of the first line to the original file. | |||
|
|
|||
| ### resourceRoot-mappings | |||
|
|
|||
| When bundling modules via resourceRoot-mappings, it might become impossible to reference the original source from a bundle's source map. For example, for a bundle located in `/test-resources`, which includes modules from `/resources`, the source map must not reference the original module via `../../resources/x/y/z` as this path rather depends on the resourceRoot-mapping and might be different at runtime. | |||
There was a problem hiding this comment.
LGTM.
Line 172 IMO should be moved into the "Source Map support" section, too.
flovogt
reviewed
Mar 22, 2022
|
|
||
| The outdated annotation convention `//@` should not be supported. All known relevant tools (Terser, TypeScript compiler) are using the new convention. See [Conventions](http://sourcemaps.info/spec.html#h.lmz475t4mvbx) in the source map specification for details. | ||
|
|
||
| Any source maps found for a resource shall be added to the source map of the bundle. Either use an [index map](http://sourcemaps.info/spec.html#h.535es3xeprgt), containing the individual source maps, or generate a new source map for the whole bundle based off them. |
There was a problem hiding this comment.
It's "based of them", isn't it?
|
|
||
|
|
||
| <!-- | ||
| This is the bulk of the RFC. Explain the design in enough detail for somebody familiar with the UI5 Tooling to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here. |
There was a problem hiding this comment.
There also further comments below
|
|
||
| ## Drawbacks | ||
|
|
||
| To be discussed. |
There was a problem hiding this comment.
if we have none, could we write it here.
|
|
||
| ## Alternatives | ||
|
|
||
| To be discussed. |
There was a problem hiding this comment.
if we have none, could we write it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read it here: RFC 0010 UI5 Builder-Bundling Refactoring
PoC: SAP/ui5-builder#657