Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] 0012 UI5 Tooling Extension API v3 #664

Merged
merged 11 commits into from
Nov 22, 2023
Merged

[RFC] 0012 UI5 Tooling Extension API v3 #664

merged 11 commits into from
Nov 22, 2023
+455 −0

Commits on Jan 24, 2023

  1. [RFC] 0012 UI5 Tooling Extension API v3

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2092045 View commit details
    Browse the repository at this point in the history

  2. Project #getReader and #getRootReader are not async anymore

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a3da6a5 View commit details
    Browse the repository at this point in the history

  3. Provide "createResource" function through a resource-factory interface 

    This allows to provide other helpful functions too, like
"createFilterReader"
    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    022c288 View commit details
    Browse the repository at this point in the history

  4. Rework createResource and getLogger APIs 

    * Replace getResourceFactory() function with a resourceFactory
  property
* Replace getLogger function with a log property passed directly to the
  task/middleware (not using the corresponding -util)
    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5027aea View commit details
    Browse the repository at this point in the history

  5. Remove getSpecVersion() from Project interface 

    With the latest changes in SAP/ui5-project#431,
the method now returns an instance of a "SpecificationVersion" class.
This would require an additional specVersion-dependent interface.

Since use cases in custom tasks and -middelare are not clear, we should
rather keep it simple for now and do not provide this method.
    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    059bb18 View commit details
    Browse the repository at this point in the history

  6. Rename callback 'requiresDependencies' => 'determineRequiredDependenc… 

    …ies'
    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    430bc12 View commit details
    Browse the repository at this point in the history

  7. Have determineRequiredDependencies callback return Set instead of Array

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5a5adc6 View commit details
    Browse the repository at this point in the history

  8. Tasks Requiring Dependencies: Small corrections

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1376e23 View commit details
    Browse the repository at this point in the history

  9. Add a table of contents

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    506e33e View commit details
    Browse the repository at this point in the history

  10. Update name restrictions with further details

    @RandomByte
    RandomByte committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6ee70e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Update chapters with implementation status 

    Making this PR ready to be merged
    @RandomByte
    RandomByte committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    43a0e0b View commit details
    Browse the repository at this point in the history