Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] specVersion 3.2 docs #902

Merged
merged 6 commits into from
Dec 13, 2023
Merged

[INTERNAL] specVersion 3.2 docs #902

merged 6 commits into from
Dec 13, 2023

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Dec 1, 2023

JIRA: CPOUI5FOUNDATION-744

Adds information about specVersion 3.2

Note: This change shouldn't be merged before:

@d3xter666 d3xter666 requested review from KlattG and a team December 1, 2023 13:17
matz3
matz3 previously requested changes Dec 4, 2023
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
d3xter666 and others added 2 commits December 5, 2023 14:15
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 requested a review from a team December 12, 2023 08:44
matz3
matz3 previously approved these changes Dec 12, 2023
@RandomByte
Copy link
Member

There's also a bunch of examples where we should update the specVersion to the latest. E.g. https://sap.github.io/ui5-tooling/stable/pages/OpenUI5/#configuration

Search & replace for specVersion: "3.1" should yield most of them

@RandomByte
Copy link
Member

RandomByte commented Dec 12, 2023

We also need to update the specVersion for ui5 init: https://github.com/SAP/ui5-cli/blob/388f7e34eba1a888b09358a460ea85621eeb447a/lib/init/init.js#L75

@d3xter666
Copy link
Contributor Author

@RandomByte , @matz3 I'll do those changes, yet they still need to after/with the release.

@d3xter666 d3xter666 merged commit e7208f6 into main Dec 13, 2023
7 checks passed
@d3xter666 d3xter666 deleted the spec-version-update-docs branch December 13, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants