Skip to content

ColumnChartWithTrend: wrong height when used in CSS grid layout #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Lukas742 opened this issue Aug 13, 2024 · 1 comment · Fixed by #7172
Closed
1 task done

ColumnChartWithTrend: wrong height when used in CSS grid layout #6204

Lukas742 opened this issue Aug 13, 2024 · 1 comment · Fixed by #7172
Labels
released

Comments

@Lukas742
Copy link
Contributor

Lukas742 commented Aug 13, 2024 •
edited
Loading

Describe the bug

If the ColumnChartWithTrend is used in a grid layout with grid-template-columns or grid-template-rows and without a defined height of the chart itself, the max-height and height is calculated incorrectly.

Isolated Example

https://stackblitz.com/edit/github-2nwdbd-ewe2ux?file=src%2FApp.tsx,package.json

Reproduction steps

  1. Got to StackBlitz
  2. See that the height of the LineChart and the one of the ColumnChart are the same

Expected Behaviour

No response

Screenshots or Videos

image

UI5 Web Components for React Version

1.29.8

UI5 Web Components Version

1.24.8

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug label Aug 13, 2024
@MarcusNotheis MarcusNotheis removed the bug label Dec 16, 2024
@Lukas742 Lukas742 mentioned this issue Apr 1, 2025
Merged
Lukas742 added a commit that referenced this issue Apr 7, 2025
@Lukas742
fix(ColumnChartWithTrend): correct height calculation (#7172)
5f98e64 
Fixes #6204
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.9.0 🎉

The release is available on v2.9.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
ui5-webcomponents-react Roadmap
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ColumnChartWithTrend): correct height calculation SAP/ui5-webcomponents-react
3 participants
@MarcusNotheis @Lukas742 @ui5-webcomponents-react-bot