Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VariantManagement): fix dirty-state and readOnly behavior #6628

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(VariantManagement): fix dirty-state and readOnly behavior #6628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d390fc2
fix(VariantManagement): add checking for selectedVariant in showSaveBtn
superdyzio Nov 17, 2024
6263f5c
fix(VariantManagement): drop hasOwnProperty from selectedVariant.read…
superdyzio Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/main/src/components/VariantManagement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,7 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>
}
}, [safeChildrenWithFavorites]);

// todo: this applies if `readOnly` is set to `false` as well since the value is read via data-attribute and is therefore a string not a boolean
const showSaveBtn = dirtyState && !Object.prototype.hasOwnProperty.call(selectedVariant, 'readOnly');
const showSaveBtn = dirtyState && selectedVariant && !selectedVariant.readOnly;

return (
<div className={variantManagementClasses} style={style} {...rest} ref={ref}>
Expand Down
Loading