Skip to content

chore(renovate): create rule for React root deps #7222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/renovate.json
Original file line number Diff line number Diff line change
@@ -70,6 +70,17 @@
"!/^@ui5//"
]
},
{
"description": "root package React versions",
"extends": ["schedule:weekly"],
"semanticCommitType": "chore",
"groupName": "non-major React dependencies",
"groupSlug": "root-react-update",
"matchFileNames": ["package.json"],
"matchUpdateTypes": ["minor", "patch"],
"matchBaseBranches": ["main"],
"matchPackageNames": ["react", "react-dom"]
},
{
"description": "Example & Template dependencies",
"extends": ["schedule:weekly"],
@@ -103,7 +114,6 @@
"matchSourceUrls": ["https://github.com/SAP/ui5-webcomponents{/,}**"]
},
{
"extends": ["schedule:weekly"],
"description": "V1 UI5WC/R dependency updates",
"matchBaseBranches": ["v1.29.x"],
"groupName": "Legacy Branch Updates",

Unchanged files with check annotations Beta

function ResizeTestComponent({ onChange }: { onChange: (event: { width: number; height: number }) => void }) {
useEffect(() => {
attachResizeHandler(onChange);
}, []);

Check warning on line 12 in packages/base/src/Device/index.cy.tsx

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array
const unregister = () => {
detachResizeHandler(onChange);
}) {
useEffect(() => {
attachOrientationChangeHandler(onChange);
}, []);

Check warning on line 32 in packages/base/src/Device/index.cy.tsx

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array
const unregister = () => {
detachOrientationChangeHandler(onChange);
const definedWebComponents = new Set<ComponentType>([]);
export const withWebComponent = <Props extends Record<string, any>, RefType = Ui5DomRef>(

Check warning on line 30 in packages/base/src/wrapper/withWebComponent.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
tagName: string,
regularProperties: string[],
booleanProperties: string[],
}
}
});
}, [Component, ...propsToApply]);

Check warning on line 191 in packages/base/src/wrapper/withWebComponent.tsx

GitHub Actions / lint

React Hook useEffect has missing dependencies: 'propsToApply' and 'ref'. Either include them or remove the dependency array

Check warning on line 191 in packages/base/src/wrapper/withWebComponent.tsx

GitHub Actions / lint

React Hook useEffect has a spread element in its dependency array. This means we can't statically verify whether you've passed the correct dependencies
useIsomorphicLayoutEffect(() => {
setAttachEvents(true);
* @param measure {IChartMeasure} Current measure object
* @param dataElement {object} Current data element
*/
highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color'];

Check warning on line 79 in packages/charts/src/components/BarChart/BarChart.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
}
interface DimensionConfig extends IChartDimension {
? dataKeys.findIndex((key) => key === chartConfig.secondYAxis?.dataKey)
: 0;
const [componentRef, chartRef] = useSyncRef<any>(ref);

Check warning on line 189 in packages/charts/src/components/BarChart/BarChart.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
const onItemLegendClick = useLegendItemClick(onLegendClick);
const labelFormatter = useLabelFormatter(primaryDimension);
speed={2}
backgroundColor={ThemingParameters.sapContent_ImagePlaceholderBackground}
foregroundColor={ThemingParameters.sapContent_ImagePlaceholderForegroundColor}
backgroundOpacity={ThemingParameters.sapContent_DisabledOpacity as any}

Check warning on line 15 in packages/charts/src/components/BarChart/Placeholder.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
>
<rect x="20" y="10" width="1" height="135" />
<rect x="20" y="20" width="85" height="15" />
* @param measure {IChartMeasure} Current measure object
* @param dataElement {object} Current data element
*/
highlightColor?: (value: number, measure: MeasureConfig, dataElement: Record<string, any>) => CSSProperties['color'];

Check warning on line 69 in packages/charts/src/components/BulletChart/BulletChart.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
}
interface DimensionConfig extends IChartDimension {
...rest
} = props;
const [componentRef, chartRef] = useSyncRef<any>(ref);

Check warning on line 149 in packages/charts/src/components/BulletChart/BulletChart.tsx

GitHub Actions / lint

Unexpected any. Specify a different type
const chartConfig: BulletChartProps['chartConfig'] = {
yAxisVisible: false,