fix(ui5-view-settings-dialog): fix circular dependency JS error (#4844)

Fixes circular dependency JS error by removing self reference associatedItem property in initSortByItems getters FIXES: #4837
SAP · Mar 2, 2022 · 057a7d8 · 057a7d8
1 parent c09b0c4
commit 057a7d8
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/packages/fiori/src/ViewSettingsDialog.js b/packages/fiori/src/ViewSettingsDialog.js
@@ -416,7 +416,6 @@ class ViewSettingsDialog extends UI5Element {
 			return {
 				text: item.text,
 				selected: item.selected,
-				associatedItem: item,
 				index,
 			};
 		});
@@ -565,8 +564,7 @@ class ViewSettingsDialog extends UI5Element {
 			sortDescending = !this._currentSettings.sortOrder[0].selected,
 			sortBy = _currentSortBySelected && _currentSortBySelected.text,
 			sortByElementIndex = _currentSortBySelected && _currentSortBySelected.index,
-			initSortIByItem = this.initSortByItems.find((item, index) => index === sortByElementIndex),
-			sortByItem = initSortIByItem && initSortIByItem.associatedItem;
+			sortByItem = this.sortItems[sortByElementIndex];
 		return {
 			sortOrder,
 			sortDescending,