Skip to content

Commit

Permalink
feat(ui5-option): title attribute handle (#4546)
Browse files Browse the repository at this point in the history
  • Loading branch information
nnaydenow authored Jan 7, 2022
1 parent a2cb0b4 commit 0c060aa
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
11 changes: 11 additions & 0 deletions packages/main/src/Option.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,17 @@ const metadata = {
type: Boolean,
},

/**
* Defines the tooltip of the component.
* @type {string}
* @defaultvalue ""
* @private
* @since 1.1.0
*/
title: {
type: String,
},

/**
* Defines the <code>icon</code> source URI.
* <br><br>
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ class Select extends UI5Element {
icon: opt.icon,
value: opt.value,
textContent: opt.textContent,
title: opt.title,
id: opt._id,
stableDomRef: opt.stableDomRef,
};
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/SelectPopover.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
icon="{{this.icon}}"
?selected="{{this.selected}}"
?focused="{{this._focused}}"
title="{{this.title}}"
?aria-selected="{{this.selected}}"
data-ui5-stable="{{this.stableDomRef}}"
>
Expand Down

0 comments on commit 0c060aa

Please sign in to comment.