Skip to content

Commit

Permalink
feat(ui5-multi-combobox): migrate to Typescript (#6559)
Browse files Browse the repository at this point in the history
MapTo0 authored Feb 28, 2023
1 parent ff34e6b commit 64d9df2
Showing 9 changed files with 663 additions and 624 deletions.
4 changes: 2 additions & 2 deletions packages/main/src/ComboBox.ts
Original file line number Diff line number Diff line change
@@ -463,8 +463,8 @@ class ComboBox extends UI5Element {
this._selectMatchingItem();
this._initialRendering = false;

const slottedIconsCount: number = this.icon.length || 0;
const arrowDownIconsCount: number = this.readonly ? 0 : 1;
const slottedIconsCount = this.icon.length || 0;
const arrowDownIconsCount = this.readonly ? 0 : 1;
this.style.setProperty("--_ui5-input-icons-count", `${slottedIconsCount + arrowDownIconsCount}`);
}

4 changes: 2 additions & 2 deletions packages/main/src/MultiComboBox.hbs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<div class="ui5-multi-combobox-root ui5-input-focusable-element"
>
<span id="{{_id}}-hiddenText-nMore" class="ui5-hidden-text">{{_tokensCountText}}</span>
<span id="ui5-multi-combobox-hiddenText-nMore" class="ui5-hidden-text">{{_tokensCountText}}</span>

{{#if hasValueState}}
<span id="{{_id}}-valueStateDesc" class="ui5-hidden-text">{{ariaValueStateHiddenText}}</span>
<span id="ui5-multi-combobox-valueStateDesc" class="ui5-hidden-text">{{ariaValueStateHiddenText}}</span>
{{/if}}

<ui5-tokenizer slot="_beginContent"
Loading

0 comments on commit 64d9df2

Please sign in to comment.