chore: fix Popover test (#1990)

- openBy has no third parameter anymore - add some delay, because even if the popover closes the test would not fail, because it is checked immediately.
SAP · Jul 27, 2020 · 93808b2 · 93808b2
1 parent d6c2cbc
commit 93808b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/main/test/pages/Popover.html b/packages/main/test/pages/Popover.html
@@ -376,7 +376,7 @@
 		});
 
 		btnQuickViewCardOpener.addEventListener("click", function (event) {
-			quickViewCard.openBy(btnQuickViewCardOpener, true, false);
+			quickViewCard.openBy(btnQuickViewCardOpener);
 
 			btnQuickViewCardOpener.setAttribute("hidden", true);
 		})

diff --git a/packages/main/test/specs/Popover.spec.js b/packages/main/test/specs/Popover.spec.js
@@ -56,9 +56,13 @@ describe("Popover general interaction", () => {
 		// act - open popover and hide opener
 		btnOpenPopover.click();
 
+		browser.pause(500);
+
 		// assert - the popover remains open, although opener is not visible
 		assert.strictEqual(popover.getAttribute("open"), "true",
 			"Popover remains open.");
+		assert.strictEqual(popover.isDisplayedInViewport(), true,
+			"Popover remains open.");
 		assert.strictEqual(btnOpenPopover.isDisplayedInViewport(), false,
 			"Opener is not available.");