fix(ui5-notifications): add missing imports for used icons (#5907)

Fixes #5905
SAP · Oct 7, 2022 · a50a22f · a50a22f
1 parent 6afff29
commit a50a22f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/packages/fiori/src/NotificationListGroupItem.js b/packages/fiori/src/NotificationListGroupItem.js
@@ -6,6 +6,11 @@ import Icon from "@ui5/webcomponents/dist/Icon.js";
 import Popover from "@ui5/webcomponents/dist/Popover.js";
 import NotificationListItemBase from "./NotificationListItemBase.js";
 
+// Icons
+import "@ui5/webcomponents-icons/dist/navigation-right-arrow.js";
+import "@ui5/webcomponents-icons/dist/overflow.js";
+import "@ui5/webcomponents-icons/dist/decline.js";
+
 // Texts
 import {
 	NOTIFICATION_LIST_GROUP_ITEM_TXT,

diff --git a/packages/fiori/src/NotificationListItem.js b/packages/fiori/src/NotificationListItem.js
@@ -10,6 +10,10 @@ import Popover from "@ui5/webcomponents/dist/Popover.js";
 import WrappingType from "@ui5/webcomponents/dist/types/WrappingType.js";
 import NotificationListItemBase from "./NotificationListItemBase.js";
 
+// Icons
+import "@ui5/webcomponents-icons/dist/overflow.js";
+import "@ui5/webcomponents-icons/dist/decline.js";
+
 // Texts
 import {
 	NOTIFICATION_LIST_ITEM_TXT,

diff --git a/packages/fiori/src/NotificationListItemBase.js b/packages/fiori/src/NotificationListItemBase.js
@@ -17,6 +17,15 @@ import NotificationOverflowActionsPopoverTemplate from "./generated/templates/No
 // Styles
 import NotificationOverflowActionsPopoverCss from "./generated/themes/NotificationOverflowActionsPopover.css.js";
 
+/**
+ * Defines the icons corresponding to the notification's priority.
+ */
+const ICON_PER_PRIORITY = {
+	[Priority.High]: "message-error",
+	[Priority.Medium]: "message-warning",
+	[Priority.Low]: "message-success",
+};
+
 /**
  * @public
  */
@@ -152,14 +161,6 @@ class NotificationListItemBase extends ListItemBase {
 		return NotificationOverflowActionsPopoverCss;
 	}
 
-	static priorityIconsMappings() {
-		return {
-			"High": "message-error",
-			"Medium": "message-warning",
-			"Low": "message-success",
-		};
-	}
-
 	get hasTitleText() {
 		return !!this.titleText.length;
 	}
@@ -169,7 +170,7 @@ class NotificationListItemBase extends ListItemBase {
 	}
 
 	get priorityIcon() {
-		return NotificationListItemBase.priorityIconsMappings()[this.priority];
+		return ICON_PER_PRIORITY[this.priority];
 	}
 
 	get overflowButtonDOM() {