Skip to content

Commit

Permalink
feat(ui5-list): introduce role property (#2235)
Browse files Browse the repository at this point in the history
  • Loading branch information
fifoosid authored Sep 28, 2020
1 parent 01a1fb0 commit d5a91e3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/main/src/List.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<ul id="{{_id}}-listUl"
class="ui5-list-ul"
role="{{_role}}"
role="{{role}}"
aria-label="{{ariaLabelТxt}}"
aria-labelledby="{{ariaLabelledBy}}"
aria-multiselectable="{{isMultiSelect}}"
Expand Down
6 changes: 4 additions & 2 deletions packages/main/src/List.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,13 @@ const metadata = {
* Used to externally manipulate the role of the list
*
* @private
* @type {String}
* @defaultvalue "listbox"
* @since 1.0.0-rc.9
*/
_role: {
role: {
type: String,
defaultValue: "listbox",
noAttribute: true,
},
},
events: /** @lends sap.ui.webcomponents.main.List.prototype */ {
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/Tree.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.headerText="{{headerText}}"
.footerText="{{footerText}}"
.noDataText="{{noDataText}}"
._role="{{_role}}"
.role="{{_role}}"
@ui5-item-click="{{_onListItemClick}}"
@ui5-item-delete="{{_onListItemDelete}}"
@ui5-selection-change="{{_onListSelectionChange}}"
Expand Down

0 comments on commit d5a91e3

Please sign in to comment.