Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-toolbar]: Overflow always open on last item with spacer #10104

Closed
1 task done
Nils-Schiwek opened this issue Oct 29, 2024 · 2 comments · Fixed by #10177
Closed
1 task done

[ui5-toolbar]: Overflow always open on last item with spacer #10104

Nils-Schiwek opened this issue Oct 29, 2024 · 2 comments · Fixed by #10177
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code Medium Prio released TOPIC P

Comments

@Nils-Schiwek
Copy link

Bug Description

I noticed, that when I use a spacer in a toolbar, the last button behind a spacer is always pushed into the overflow state (... menu) even though there is enough space.
{5D87F45D-F149-403F-9CC8-1B9A09DC520E}

Here is an example from your documentation

Interestingly, if you add another button in this setup, the button will now be rendered and again the last button behind the spacer is pushed into the overflow.

Affected Component

ui5-toolbar

Expected Behaviour

All ToolbarButtons should be visible (given there is enough space) when a ToolbarSpacer is added.

Isolated Example

No response

Steps to Reproduce

  1. Use a Toolbar with 2 ToolbarButtons
  2. Add a Toolbar Spacer between them
  3. Notice the last Button is hidden behind the overflow menu.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.3.0

Browser

Edge

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Nils-Schiwek Nils-Schiwek added the bug This issue is a bug in the code label Oct 29, 2024
@dimovpetar dimovpetar self-assigned this Oct 29, 2024
@dimovpetar
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p ,

This issue is reproducible.

Best regards,
Petar

@dimovpetar dimovpetar removed their assignment Oct 29, 2024
@plamenivanov91 plamenivanov91 self-assigned this Nov 7, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Nov 13, 2024
@plamenivanov91
feat(ui5-toolbar): fixed spacer behavior
11f002c 
There was a bug where if there is a spacer before the last item, the
last item would always overflow.
This change fixes the issue

Fixes: SAP#10104
@plamenivanov91 plamenivanov91 mentioned this issue Nov 13, 2024
Merged
plamenivanov91 added a commit that referenced this issue Nov 18, 2024
@plamenivanov91
feat(ui5-toolbar): fixed spacer behavior (#10177)
b3625ac 
* feat(ui5-toolbar): fixed spacer behavior

There was a bug where if there is a spacer before the last item, the
last item would always overflow.
This change fixes the issue

Fixes: #10104
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Nov 18, 2024
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.5.0-rc.1 🎉

The release is available on v2.5.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code Medium Prio released TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-toolbar): fixed spacer behavior plamenivanov91/ui5-webcomponents
4 participants
@plamenivanov91 @dimovpetar @ui5-webcomponents-bot @Nils-Schiwek