Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-expandable-text): add ExpandableText component #10220

Merged
merged 33 commits into from
Dec 9, 2024
Merged

feat(ui5-expandable-text): add ExpandableText component #10220

merged 33 commits into from
Dec 9, 2024

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented Nov 20, 2024 •
edited
Loading

BGSOFUIRODOPI-3367

@dimovpetar dimovpetar marked this pull request as draft November 20, 2024 13:59
@dimovpetar
test: add first test
e1efcec
@dimovpetar
test: add more tests
d635a18
@dimovpetar
test: add tests for popover
b1ffd45
@dimovpetar
test: simplify them using aliases
302ddf4
@dimovpetar
test: add tests for empty text and 0 max characters
3a13eb7
@dimovpetar
feat: implement emtpyIndicatorMode
4aae06c
@dimovpetar
feat: take Show More and Show Less from messagebundle
aae938e
@dimovpetar
feat: add mobile support
b17b561
@dimovpetar
fix: closing popover on toggle click now works
6995c88
@dimovpetar
test: add kh handling tests
0ff19cb
@dimovpetar
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
c15972e 
…_text
@dimovpetar
docs: add basic sample
6a69688
@dimovpetar
docs: fix closing tag issue
b0a9117
@dimovpetar
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
e2f1355 
…_text
@dimovpetar
feat: add SR support
3bc1f3b
@dimovpetar
fix: apply proper popover paddings
915a1fa
@dimovpetar
refactor: import i18n texts in tests
a17e608
@dimovpetar
refactor: tests
3d10731
@dimovpetar
docs: add samples
1ebb1df
@dimovpetar
test: add rtl test sample
8a0374a
@dimovpetar
chore: update popover workaround
a8874fe
@dimovpetar
feat: change maxCharacters default value to 100
452187f
@dimovpetar
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
c47e273 
…_text
@dimovpetar
fix: add workaround for Show Less opening the popover
e8f0d32
@dimovpetar
test: use text from i18n bundle
c00b2da
@dimovpetar
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
a49c056 
…_text
@dimovpetar
docs: update
4888695
@dimovpetar dimovpetar marked this pull request as ready for review December 5, 2024 13:28
TeodorTaushanov
TeodorTaushanov requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add aria-labelledby of the Popover that points to the text.
  • Increase the height of the public samples

packages/main/src/ExpandableText.ts Outdated Show resolved Hide resolved
@dimovpetar dimovpetar requested a review from Stoev December 6, 2024 07:56
@dimovpetar
Copy link
Contributor Author

  • Add aria-labelledby of the Popover that points to the text.
  • Increase the height of the public samples

Done

vladitasev
vladitasev reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of API - no slots, just properties

Stoev
Stoev reviewed Dec 6, 2024
View reviewed changes
packages/main/src/i18n/messagebundle.properties Outdated Show resolved Hide resolved
packages/main/src/ExpandableText.ts Outdated Show resolved Hide resolved
Stoev
Stoev reviewed Dec 9, 2024
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA all good.

@dimovpetar dimovpetar merged commit 7667585 into main Dec 9, 2024
10 checks passed
@dimovpetar dimovpetar deleted the feat_exp_text branch December 9, 2024 11:31
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.6.0-rc.0 🎉

The release is available on v2.6.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev left review comments

@Stoev Stoev Stoev left review comments

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

@alexandar-mitsev alexandar-mitsev Awaiting requested review from alexandar-mitsev

@BorisDafov BorisDafov Awaiting requested review from BorisDafov

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimovpetar @ui5-webcomponents-bot @TeodorTaushanov @Stoev @vladitasev