Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-expandable-text): add ExpandableText component #10220

Merged
merged 33 commits into from
Dec 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1296788
feat(ui5-expandable-text): add ExpandableText component
dimovpetar Nov 20, 2024
e1efcec
test: add first test
dimovpetar Nov 20, 2024
d635a18
test: add more tests
dimovpetar Nov 20, 2024
b1ffd45
test: add tests for popover
dimovpetar Nov 21, 2024
302ddf4
test: simplify them using aliases
dimovpetar Nov 21, 2024
3a13eb7
test: add tests for empty text and 0 max characters
dimovpetar Nov 21, 2024
4aae06c
feat: implement emtpyIndicatorMode
dimovpetar Nov 21, 2024
aae938e
feat: take Show More and Show Less from messagebundle
dimovpetar Nov 21, 2024
b17b561
feat: add mobile support
dimovpetar Nov 22, 2024
6995c88
fix: closing popover on toggle click now works
dimovpetar Nov 22, 2024
0ff19cb
test: add kh handling tests
dimovpetar Nov 22, 2024
c15972e
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
dimovpetar Nov 22, 2024
6a69688
docs: add basic sample
dimovpetar Nov 22, 2024
b0a9117
docs: fix closing tag issue
dimovpetar Dec 2, 2024
e2f1355
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
dimovpetar Dec 2, 2024
3bc1f3b
feat: add SR support
dimovpetar Dec 2, 2024
915a1fa
fix: apply proper popover paddings
dimovpetar Dec 2, 2024
a17e608
refactor: import i18n texts in tests
dimovpetar Dec 2, 2024
3d10731
refactor: tests
dimovpetar Dec 2, 2024
1ebb1df
docs: add samples
dimovpetar Dec 2, 2024
8a0374a
test: add rtl test sample
dimovpetar Dec 2, 2024
a8874fe
chore: update popover workaround
dimovpetar Dec 3, 2024
452187f
feat: change maxCharacters default value to 100
dimovpetar Dec 3, 2024
c47e273
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
dimovpetar Dec 3, 2024
e8f0d32
fix: add workaround for Show Less opening the popover
dimovpetar Dec 3, 2024
c00b2da
test: use text from i18n bundle
dimovpetar Dec 3, 2024
a49c056
Merge branch 'main' of github.com:SAP/ui5-webcomponents into feat_exp…
dimovpetar Dec 4, 2024
4888695
docs: update
dimovpetar Dec 5, 2024
72b6db7
docs: use tables in samples
dimovpetar Dec 5, 2024
e932222
fix: set accessible-name-ref of the popover
dimovpetar Dec 6, 2024
3fa4184
docs: increase samples height
dimovpetar Dec 6, 2024
dc7ed48
docs: fix module path in JSdoc
dimovpetar Dec 6, 2024
e00ab1b
docs: reword some sentences
dimovpetar Dec 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add rtl test sample
dimovpetar committed Dec 2, 2024

Verified

This commit was signed with the committer’s verified signature.
ExE-Boss ExE Boss
commit 8a0374ab0a26113ea911bf4f1110329fce613031
3 changes: 2 additions & 1 deletion packages/main/test/pages/ExpandableText.html
Original file line number Diff line number Diff line change
@@ -4,7 +4,6 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta charset="utf-8">
<title>ExpandableText</title>
<script src="%VITE_BUNDLE_PATH%" type="module"></script>
</head>
@@ -45,4 +44,6 @@ <h3>Off</h3>
<h3>Off, with Text</h3>
<ui5-expandable-text empty-indicator-mode="Off" text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec ac risus nec lorem pretium fringilla. Sed non eros nec nisl vehicula finibus. Suspendisse potenti. Quisque nec odio et est pharetra semper. Nullam nec ligula in risus laoreet pulvinar. Nullam et turpis ac eros viverra facilisis. Nullam et turpis ac eros viverra facilisis"></ui5-expandable-text>

<h3>RTL</h3>
<ui5-expandable-text dir="rtl" text="וְאָהַבְתָּ אֵת יְיָ | אֱלֹהֶיךָ, בְּכָל-לְבָֽבְךָ, וּבְכָל-נַפְשְׁךָ, וּבְכָל-מְאֹדֶֽךָ. וְהָיוּ הַדְּבָרִים הָאֵלֶּה, אֲשֶׁר | אָֽנֹכִי מְצַוְּךָ" max-characters="50"></ui5-expandable-text>
</html>