Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-input): remove initial tabindex 0 from suggestions #10304

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fix(ui5-input): remove initial tabindex 0 from suggestions #10304

merged 3 commits into from
Dec 10, 2024

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Dec 4, 2024

FIXES: #9340

elenastoyanovaa
elenastoyanovaa requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some examples do not work, also add a test to check that tabindex=0 is not applied to all types of items

elenastoyanovaa
elenastoyanovaa requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation with JAWS seems to work. Please update the item roles as described in the issue, also add tests for that.

@MapTo0 MapTo0 merged commit 5871352 into main Dec 10, 2024
10 checks passed
@MapTo0 MapTo0 deleted the input-remove-sugg-tabindex branch December 10, 2024 13:12
@MapTo0 MapTo0 mentioned this pull request Dec 10, 2024
Closed
1 task
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.6.0-rc.0 🎉

The release is available on v2.6.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Input]: keyboard navigation issue for input suggestion in JAWS
3 participants
@MapTo0 @ui5-webcomponents-bot @elenastoyanovaa