Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input]: keyboard navigation issue for input suggestion in JAWS #9340

Closed
1 task done
pankajpandey01 opened this issue Jun 28, 2024 · 6 comments · Fixed by #10304
Closed
1 task done

[Input]: keyboard navigation issue for input suggestion in JAWS #9340

pankajpandey01 opened this issue Jun 28, 2024 · 6 comments · Fixed by #10304
Assignees

Comments

@pankajpandey01
Copy link

Describe the bug

[Input]: keyboard navigation issue for input suggestion in JAWS
-Can not navigate to all item in input suggestions with keyboard in JAWS. Focus is stuck on one item after navigating few items and JAWS is announcing background element.

Isolated Example

No response

Reproduction steps

  1. Open JAWS 2024
  2. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-input--docs
  3. Go to "Input with customizable SuggestionItem" section
  4. enter "a" in input box
  5. Start navigating to suggestion items with keyboard

Observed that focus is stuck on 7th item and JAWS started announcing background element.

Expected Behaviour

All items should be navigable through keyboard in JAWS. Focus should not be lost.

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.0

Browser

Chrome, Edge

Operating System

Windows 11

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@pankajpandey01 pankajpandey01 added the bug This issue is a bug in the code label Jun 28, 2024
@Lukas742
Copy link
Collaborator

Lukas742 commented Jul 1, 2024

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jul 1, 2024
@nikoletavnv nikoletavnv self-assigned this Jul 1, 2024
@nikoletavnv
Copy link
Member

Dear @SAP/ui5-webcomponents-topic-rl ,

I could reproduce this issue when JAWS is running. Follow the steps reported by @pankajpandey01. When navigating through the suggestion items with the arrow keys, the navigation gets stuck at "Iceland" and item "Moldova" is never reached.
If JAWS is not running, the issue is not reproduced when navigating with the arrow keys.

I also tested on 1.124 and the 2.0.0-rc.6 and normal suggestions (not custom). The issue there is even more severe, as the navigation through items gets stuck at the first suggestion item. Again it is only reproduceable when JAWS is running and reading the items.

For reference - the problem does not exist in combo-box.

Kind regards,
Nikoleta Terzieva

@nikoletavnv nikoletavnv removed their assignment Jul 1, 2024
@nikoletavnv
Copy link
Member

I could not reproduce the issue with NVDA reader on Windows.

@elenastoyanovaa
Copy link
Contributor

There are several issues to be fixed herehere:

  • The role of the list should be changed to listbox and the listitem roles to option. This is to be done in both 2.0 and 1.24. For 2.0 we should like in: refactor(ui5-option): adjust accessibility roles #9611 .For 1.24 accessible-role attribute for the list and listitem should be set
  • Unfortunately the above adjustment does not solve the issue, because the most severe problem is that the list item receives a tabindex="0" which really confuses JAWS and it switches modes until getting stuck. The tabindex="0" should not be set. I tried setting the forced-tab-index but this did not worked so I started overwriting effectiveTabIndex of the ListItemBase in all our types of suggestion items and it seems that this might work, but it was a lot of effort and I did not have the capacity to finish it. Removing the tabindex will resolve the issue for both versions. Should be applied to all items - groups, suggestions.

Kind Regards,
Elena

@elenastoyanovaa elenastoyanovaa removed their assignment Sep 16, 2024
@elenastoyanovaa elenastoyanovaa moved this from In progress to New Issues in Maintenance - Topic RL Sep 16, 2024
@Okiana Okiana assigned Okiana and unassigned Okiana Oct 14, 2024
@Okiana Okiana assigned Okiana and unassigned Okiana Nov 11, 2024
@MapTo0 MapTo0 moved this from New Issues to In progress in Maintenance - Topic RL Dec 4, 2024
@MapTo0 MapTo0 self-assigned this Dec 4, 2024
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Dec 10, 2024
@MapTo0 MapTo0 reopened this Dec 10, 2024
@github-project-automation github-project-automation bot moved this from Completed to In progress in Maintenance - Topic RL Dec 10, 2024
@MapTo0
Copy link
Member

MapTo0 commented Dec 10, 2024

main is merged, waiting for #10304 #10355

@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.6.0-rc.0 🎉

The release is available on v2.6.0-rc.0

Your semantic-release bot 📦🚀

@MapTo0 MapTo0 closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

7 participants