Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-dynamic-page]: DynamicPageHeader can still be interactive when loading #10399

Closed
1 task done
ksblklu02 opened this issue Dec 17, 2024 · 3 comments · Fixed by #10425
Closed
1 task done

[ui5-dynamic-page]: DynamicPageHeader can still be interactive when loading #10399

ksblklu02 opened this issue Dec 17, 2024 · 3 comments · Fixed by #10425
Assignees
Labels
bug This issue is a bug in the code SAP SF TOPIC P

Comments

@ksblklu02
Copy link

Bug Description

When DynamicPage is wrapped in ui5-busy-indicator, the header area can still be interactive when busy status set to active.

Affected Component

ui5-dynamic-page

Expected Behaviour

DynamicPage header area should not be interactive when wrapped in active busy indicator.

Isolated Example

https://stackblitz.com/edit/github-gafhlvhg?file=src%2FApp.tsx

Steps to Reproduce

  1. Go to https://stackblitz.com/edit/github-gafhlvhg?file=src%2FApp.tsx
  2. Click on the "set loading" button
  3. See the DynamicPage header is still interactive when loading
Image

Log Output, Stack Trace or Screenshots

No response

Priority

High

UI5 Web Components Version

2.5.0

Browser

Chrome

Operating System

MacOS

Additional Context

When the whole page is loading, interactive page header is not expected. Because in some cases the loading is triggered from the page header, if user clicks on the page header elements during loading would duplicate the loading action and cause performance or other potential issue.

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@ksblklu02 ksblklu02 added the bug This issue is a bug in the code label Dec 17, 2024
@Valkanister Valkanister self-assigned this Dec 17, 2024
@ilhan007
Copy link
Member

Hi @ksblklu02 would this workaround fine with you - it's resetting the z-index of the dynamic page, when "loading" is true.

@ksblklu02
Copy link
Author

Hi @ilhan007
Many thanks for your quick support and this workaround looks good. And we also want to confirm will @ui5/webcomponents provide internal fix in the future? Or the current z-index for the DynamicPage header is expected behavior?

@Valkanister
Copy link

"Hello @SAP/ui5-webcomponents-topic-p, take a look of this issue with the DynamicPage."

@NakataCode NakataCode self-assigned this Dec 19, 2024
@NakataCode NakataCode moved this from Issues to In Progress in Maintenance - Topic P Dec 19, 2024
NakataCode added a commit that referenced this issue Dec 20, 2024
Corrected the z-index of .ui5-dynamic-page-title-header-wrapper to ensure it does not overlap the busy indicator.

Fixes: #10399
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code SAP SF TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants