Skip to content

[ui5-side-navigation]: collapse/expand icon has different spacing then the visual design #11171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
alexandar-mitsev opened this issue Mar 25, 2025 · 3 comments · Fixed by #11208
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio released TOPIC RD
Milestone

Comments

@alexandar-mitsev
Copy link
Contributor

Bug Description

The size and margins for the expand/collapse icon for single click area item are different then the one shown in the visual design.

Open: http://localhost:3000/components/fiori/SideNavigation/ to reproduce. See the sample for "Unselectable parents".

The size and margin of the icon are margin left 16px, padding left 4px, width 36px, padding right 6px.
Image

While it should be margin left 8px, no padding, width 36px, padding or margin right 6px. See VD https://wiki.one.int.sap/wiki/display/visualcore/Side+Navigation
Image
Image

Affected Component

ui5-side-navigation

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.9.0-rc.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@alexandar-mitsev alexandar-mitsev added bug This issue is a bug in the code TOPIC RD labels Mar 25, 2025
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Mar 25, 2025
LidiyaGeorgieva added a commit that referenced this issue Mar 28, 2025
- collapse/expand icon has spacings according to the visual design
- touch (click) area of the collapse/expand is correct now
(before it was with smaller height than the item)

fixes: #11171
@s-todorova s-todorova added this to the 2.10.0 milestone Apr 2, 2025
@s-todorova s-todorova moved this from New Issues to In Progress in Maintenance - Topic RD Apr 2, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic RD Apr 15, 2025
Copy link

This issue has been closed. To reopen, just leave a comment!

1 similar comment
Copy link

This issue has been closed. To reopen, just leave a comment!

@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.10.0-rc.1 🎉

The release is available on v2.10.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio released TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants