Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-combobox: Enter key is not working #1940

Closed
2bno1 opened this issue Jul 10, 2020 · 0 comments · Fixed by #1948
Closed

ui5-combobox: Enter key is not working #1940

2bno1 opened this issue Jul 10, 2020 · 0 comments · Fixed by #1948
Assignees
Labels
ACC enhancement New feature or request

Comments

@2bno1
Copy link

2bno1 commented Jul 10, 2020

Describe the bug
When there's item selected, press Enter key, the popover is not dismissed.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/ComboBox/
  2. Input 'I', the popover is shown and first item (Item 1) is selected by default
  3. Press Enter key, the popover is not dismissed

Expected behavior
If there's item selected, pressing Enter should dismiss the popover.

Screenshots
1594346163397

Context

  • UI5 Web Components version
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components
ui5-combobox

@ilhan007 ilhan007 self-assigned this Jul 10, 2020
@ilhan007 ilhan007 added enhancement New feature or request ACC labels Jul 10, 2020
@ilhan007 ilhan007 assigned nnaydenow and unassigned ilhan007 Jul 10, 2020
nnaydenow added a commit that referenced this issue Jul 14, 2020
Now, popover is closed when "Enter" key is pressed.

Fixes: #1940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants