Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility Bug - TabContainer] The number of aria-setsize attribute is not set correctly #2035

Closed
Hubery-Shen opened this issue Jul 30, 2020 · 0 comments · Fixed by #2046
Closed

[Accessibility Bug - TabContainer] The number of aria-setsize attribute is not set correctly #2035

Hubery-Shen opened this issue Jul 30, 2020 · 0 comments · Fixed by #2046
Assignees
@ilhan007
Labels
ACC SAP SF SF_ACC

Comments

@Hubery-Shen
Copy link

Hubery-Shen commented Jul 30, 2020 •
edited
Loading

Hi UI5 WebComponents team,
I am Hubery Shen from Successfactors.

Bug description:
The number of aria-setsize attribute is not set correctly in TabContainer component
The number of aria-setsize is bigger than the actual count of tabs

Screen Shot 2020-07-30 at 10 53 33 AM

Demo page
https://sap.github.io/ui5-webcomponents/playground/components/TabContainer/
In this demo, the tab count is 5, but aria-setsize is set 6
@ilhan007 ilhan007 self-assigned this Jul 31, 2020
@ilhan007 ilhan007 mentioned this issue Jul 31, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 3, 2020
@ilhan007
fix(ui5-tabcontainer): Fix ARIA posinset and setsize values (#2046)
c6fcf69 
The separator should be excluded, when calculating the aria-posinset and aria-setsize values.

FIXES: #2035
ilhan007 added a commit that referenced this issue Aug 3, 2020
@ilhan007
fix(ui5-tabcontainer): Fix ARIA posinset and setsize values (#2046)
506c902 
The separator should be excluded, when calculating the aria-posinset and aria-setsize values.

FIXES: #2035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
ACC SAP SF SF_ACC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-tabcontainer): Fix ARIA posinset and setsize values SAP/ui5-webcomponents
3 participants
@ilhan007 @nikolay-kolarov @Hubery-Shen