Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-shellbar: logos wider than 3rem are being compressed #2066

Closed
Lukas742 opened this issue Aug 5, 2020 · 0 comments · Fixed by #2077
Closed

ui5-shellbar: logos wider than 3rem are being compressed #2066

Lukas742 opened this issue Aug 5, 2020 · 0 comments · Fixed by #2077
Assignees
Labels
bug This issue is a bug in the code

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Aug 5, 2020

Describe the bug
If an image wider than 3rem is added to the logo slot of the ui5-shellbar, it is compressed. It's now necessary to overwrite the max-width of the <img> (which is 3rem) to display the image at the correct scale. In rc7 this was not required.

To reproduce
Steps to reproduce the behavior:

  1. Implement a ui5-shellbar component
  2. Add the logo slot with an image wider than high (should be wider than 3rem inside the shellbar)

Isolated example
1.0.0-rc.8:
https://codesandbox.io/s/ui5-webcomponents-cs3zz?file=/index.html:226-307

1.0.0-rc.7:
https://codesandbox.io/s/ui5-webcomponents-w4k2w?file=/index.html

Expected behavior
Either it should be mentioned in the documentation, that max-width has to be overwritten to display the logo with correct dimension, or the logo should behave like it did with the rc7 version, just with an image tag.

Screenshots
Screenshot 2020-08-05 at 09 47 01

Context

  • UI5 Web Components version: 1.0.0-rc.8:
@ilhan007 ilhan007 added the bug This issue is a bug in the code label Aug 7, 2020
@nnaydenow nnaydenow self-assigned this Aug 10, 2020
nnaydenow added a commit that referenced this issue Aug 13, 2020
By specification logo should have only 2rem height limitation.

Fixes #2066
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
By specification logo should have only 2rem height limitation.

Fixes #2066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants