Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input): fix value state msg appearance #2075

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Aug 7, 2020

  • Fixes the height when the value state msg is displayed as standalone popover, previously too large.
  • Fixes the height within the suggestions popover, previously the message used to be cut off.

FIXES #2070

Before
Screenshot 2020-08-07 at 10 53 36 AM
Screenshot 2020-08-07 at 10 41 28 AM

After
Screenshot 2020-08-07 at 10 54 28 AM
Screenshot 2020-08-07 at 10 54 47 AM

Fixes the height when the value state msg is displayed as standalone popovr and within the suggestions popover

FIXES #2070
@ilhan007 ilhan007 merged commit edfe8ca into master Aug 10, 2020
@ilhan007 ilhan007 deleted the fix-input-vsm branch August 10, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box containing ValueStateMessage is too large
2 participants