Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input): fix value state msg appearance #2075

Merged
merged 1 commit into from
Aug 10, 2020
Merged

fix(ui5-input): fix value state msg appearance #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/main/src/Input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ class Input extends UI5Element {
}

/**
* Checks if the popover is open.
* Checks if the value state popover is open.
* @returns {Boolean} true if the popover is open, false otherwise
* @public
*/
Expand Down Expand Up @@ -1034,6 +1034,7 @@ class Input extends UI5Element {
return {
popoverValueState: {
"ui5-valuestatemessage-root": true,
"ui5-responsive-popover-header": !this.isOpen(),
"ui5-valuestatemessage--success": this.valueState === ValueState.Success,
"ui5-valuestatemessage--error": this.valueState === ValueState.Error,
"ui5-valuestatemessage--warning": this.valueState === ValueState.Warning,
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/InputPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
class="ui5-valuestatemessage-popover"
placement-type="Bottom"
>
<div slot="header" class="ui5-responsive-popover-header {{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
{{> valueStateMessage}}
</div>
</ui5-popover>
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/themes/ResponsivePopoverCommon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
.ui5-responsive-popover-header .row {
box-sizing: border-box;
padding: 0.25rem 1rem;
height: 2.5rem;
min-height: 2.5rem;
display: flex;
justify-content: center;
align-items: center;
Expand Down