Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][ui5-dialog][ui5-toast] The active ui5-dialog (modal) can not overlaid ui5-toast #2110

Closed
Hubery-Shen opened this issue Aug 19, 2020 · 0 comments · Fixed by #2118
Closed

[BUG][ui5-dialog][ui5-toast] The active ui5-dialog (modal) can not overlaid ui5-toast #2110

Hubery-Shen opened this issue Aug 19, 2020 · 0 comments · Fixed by #2118
Assignees
@ilhan007
Labels
High Prio SAP SF
Milestone
1.0.0-rc.9

Comments

@Hubery-Shen
Copy link

Dear colleagues,

I am from Successfactors web experience Shanghai team.

Describe the bug
The active ui5-dialog (modal) can not overlaid ui5-toast
message toast

To reproduce
Steps to reproduce the behavior:

  1. Use both ui5-toast and ui5-dialog components.
  2. Active ui5-dialog & ui5-toast
  3. You can see the fact that the active ui5-dialog (modal) can not overlaid ui5-toast

Expected behavior
The active ui5-dialog (modal) can overlaid ui5-toast

Environment

UI5 Web Components version: 0.23.0
OS/Platform: macOS 10.15.6
Browser (if relevant): Chrome 84
Other information: screen reader - NVDA

Thanks
Hubery Shen
@ilhan007 ilhan007 self-assigned this Aug 19, 2020
ilhan007 added a commit that referenced this issue Aug 19, 2020
@ilhan007
fix(ui5-toast) avoid overlaying Dialog and Popover
0d45caa 
Remove hardcoded z-index of 999 and use the shared z-index between all popups.

FIXES #2110
@ilhan007 ilhan007 mentioned this issue Aug 19, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 19, 2020
@ilhan007
fix(ui5-toast) avoid overlaying Dialog and Popover (#2118)
1971a54 
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation,
but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened.

FIXES #2110
ilhan007 added a commit that referenced this issue Aug 20, 2020
@ilhan007
fix(ui5-toast) avoid overlaying Dialog and Popover (#2118)
54b7e76 
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation,
but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened.

FIXES #2110
@ilhan007 ilhan007 added this to the 1.0.0-rc.9 milestone Sep 2, 2020
ilhan007 added a commit that referenced this issue Oct 17, 2020
@ilhan007
fix(ui5-toast) avoid overlaying Dialog and Popover (#2118)
99eb611 
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation,
but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened.

FIXES #2110
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
fix(ui5-toast) avoid overlaying Dialog and Popover (#2118)
dc8ac4c 
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation,
but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened.

FIXES #2110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
High Prio SAP SF
Projects
None yet
Milestone
1.0.0-rc.9
Development

Successfully merging a pull request may close this issue.

fix(ui5-toast) avoid overlaying Dialog and Popover SAP/ui5-webcomponents
2 participants
@ilhan007 @Hubery-Shen