Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-popover: [BUG] ui5-popover displays error when Left is set to horizontalAlign attribute #2111

Closed
Hubery-Shen opened this issue Aug 19, 2020 · 3 comments · Fixed by #2129
Assignees

Comments

@Hubery-Shen
Copy link

Dear colleagues,

I am from Successfactors web experience Shanghai team.

Describe the bug
ui5-popover displays error when Left is set to horizontalAlign attribute
popover

Context
UI5 Web Components version: 0.23.0
OS/Platform: macOS 10.15.6
Browser (if relevant): Microsoft Edge
Other information: screen reader - NVDA

Thanks
Hubery Shen

@ilhan007
Copy link
Member

Hello @Hubery-Shen

is it possible to send us URL where we can look at the issue or create a small example in codesandbox?

BR,
ilhan

@Hubery-Shen
Copy link
Author

Hi @ilhan007 ,

sure, I will write a quick example for it later.
thanks for your support.

BR
Hubery Shen

@Hubery-Shen
Copy link
Author

Hubery-Shen commented Aug 20, 2020

Hi @ilhan007 ,

I have created a quick example for this issue: https://github.com/Hubery-Shen/UI5-WebComponent-Examples

snapshot:
Screen Shot 2020-08-20 at 9 52 46 AM

code is:

// Import React Framework
import React, { useEffect, useRef } from "react";

// Import UI5 libs
import "react-app-polyfill/stable";
import "@ui5/webcomponents/dist/Assets.js";
import "@ui5/webcomponents-icons/dist/Assets.js";

// Import Tested Component
import "@ui5/webcomponents/dist/Popover.js";

// Import CSS
import "./App.css";

function App() {
  const targetRef = useRef(null);
  const popoverRef = useRef(null);
  useEffect(() => {
    popoverRef.current && popoverRef.current.openBy(targetRef.current);
  }, []);
  return (
      <div className="App">
        <div ref={targetRef} id="target" style={{ width: "100%", height: "100px", background: "lightblue" }} />
        <div className="snippet">
          <ui5-popover ref={popoverRef} horizontal-align="Left" id="hello-popover" header-text="Newsletter subscription">
            <div className="popover-content">
              <div className="flex-column">
                <ui5-label htmlFor="emailInput">Email:</ui5-label>
                <ui5-input id="emailInput" className="samples-margin-top" placeholder="Enter Email" />
              </div>
            </div>
            <div slot="footer" className="popover-footer">
              <div style={{ flex: 1 }} />
              <ui5-button id="closePopoverButton" design="Emphasized">
                Subscribe
              </ui5-button>
            </div>
          </ui5-popover>
        </div>
      </div>
  );
}

export default App;

@ilhan007 ilhan007 self-assigned this Aug 20, 2020
ilhan007 added a commit that referenced this issue Aug 21, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
ilhan007 added a commit that referenced this issue Aug 21, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
ilhan007 added a commit that referenced this issue Oct 17, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
ilhan007 added a commit that referenced this issue Nov 11, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants