fix(ui5-toast) avoid overlaying Dialog and Popover #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded z-index of 999 and use the shared z-index between all popups. FIXES #2110
vladitasev
approved these changes
Aug 19, 2020
ilhan007
added a commit
that referenced
this pull request
Aug 20, 2020
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation, but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened. FIXES #2110
ilhan007
added a commit
that referenced
this pull request
Oct 17, 2020
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation, but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened. FIXES #2110
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation, but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened. FIXES #2110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded z-index of 999. As the Toast is not a popup by implementation,
but is a popup by nature, it should use the shared "z-index" between the Popups (Dialog and Popover) to appear correctly under or over them, depending on the place it has been opened.
FIXES #2110