Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItem: visual deviations from Fiori 3 - Part 1 #2218

Closed
7 tasks done
ilhan007 opened this issue Sep 14, 2020 · 0 comments · Fixed by #2314
Closed
7 tasks done

ListItem: visual deviations from Fiori 3 - Part 1 #2218

ilhan007 opened this issue Sep 14, 2020 · 0 comments · Fixed by #2314
Assignees
@nnaydenow
Labels
Medium Prio TOPIC P
Milestone
1.0.0-rc.9

Comments

@ilhan007
Copy link
Member

ilhan007 commented Sep 14, 2020 •
edited by nnaydenow
Loading

The StandardListItem visual deviates from the Fiori 3 spec in these categories, described in the VD wiki

List (Fiori 3) - Selection

  • ui5-list height should be 44px in Cozy
  • CheckBox paddings should overlap ui5-list padding (Padding area position: left aligned and vertically centered within the list item. It superimposes the left List padding - spec)
  • CheckBox left offset - always the same
  • CheckBox vertical position

top - when the items has 2 lines of text
center - when the items has 1 line of text

List (Fiori 3) - StandartListItem

  • ui5-li height should be 44px in Cozy
  • icon should be 18px in cozy

List (Fiori 3) - StandartListItem with byline
@nnaydenow nnaydenow self-assigned this Oct 1, 2020
@nnaydenow nnaydenow mentioned this issue Oct 1, 2020
Merged
nnaydenow added a commit that referenced this issue Oct 2, 2020
@nnaydenow
fix(ui5-li): correct image size
5c51dc6 
When ui5-li has image and byline (description), the image should have 3rem height and 3rem width in Compact and Cozy mode. In addition its angles should be rounded.

Part of #2218
@nnaydenow nnaydenow mentioned this issue Oct 2, 2020
Merged
@ilhan007 ilhan007 added this to the 1.0.0-rc.10 milestone Oct 2, 2020
@nnaydenow nnaydenow mentioned this issue Oct 2, 2020
Closed
nnaydenow added a commit that referenced this issue Oct 2, 2020
@nnaydenow
fix(ui5-li): correct sizes
2faad25 
Corrected ui5-li and its icon sizes in Cozy mode.

Part of #2218
@ilhan007 ilhan007 changed the title ListItem: visual deviations from Fiori 3 ListItem: visual deviations from Fiori 3 part 1 Oct 6, 2020
@ilhan007 ilhan007 changed the title ListItem: visual deviations from Fiori 3 part 1 ListItem: visual deviations from Fiori 3 - Part 1 Oct 6, 2020
@nnaydenow nnaydenow mentioned this issue Oct 7, 2020
Merged
ilhan007 pushed a commit that referenced this issue Oct 7, 2020
@nnaydenow
fix(ui5-li): fix visual deviations from Fiori 3 (#2314)
d430632 
Changes:
- info text is align centrally and it is align bottom if description attribute exists
- title text is align centrally and it is align top if description attribute exists
- item's height is changed to 5rem if description / image attribute exist
- checkbox / radio button is positioned correctly

Fixes #2297
Fixes #2218
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.10, 1.0.0-rc.9 Oct 8, 2020
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@nnaydenow @ilhan007
fix(ui5-li): correct image size
6332393 
When ui5-li has image and byline (description), the image should have 3rem height and 3rem width in Compact and Cozy mode. In addition its angles should be rounded.

Part of #2218
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@nnaydenow @ilhan007
fix(ui5-li): correct sizes
85dc25d 
Corrected ui5-li and its icon sizes in Cozy mode.

Part of #2218
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@nnaydenow @ilhan007
fix(ui5-li): fix visual deviations from Fiori 3 (#2314)
ff155d1 
Changes:
- info text is align centrally and it is align bottom if description attribute exists
- title text is align centrally and it is align top if description attribute exists
- item's height is changed to 5rem if description / image attribute exist
- checkbox / radio button is positioned correctly

Fixes #2297
Fixes #2218
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@nnaydenow @ilhan007
fix(ui5-li): correct image size
ba04673 
When ui5-li has image and byline (description), the image should have 3rem height and 3rem width in Compact and Cozy mode. In addition its angles should be rounded.

Part of #2218
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@nnaydenow @ilhan007
fix(ui5-li): correct sizes
2ba1ef6 
Corrected ui5-li and its icon sizes in Cozy mode.

Part of #2218
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@nnaydenow @ilhan007
fix(ui5-li): fix visual deviations from Fiori 3 (#2314)
6f325c5 
Changes:
- info text is align centrally and it is align bottom if description attribute exists
- title text is align centrally and it is align top if description attribute exists
- item's height is changed to 5rem if description / image attribute exist
- checkbox / radio button is positioned correctly

Fixes #2297
Fixes #2218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnaydenow nnaydenow

Labels
Medium Prio TOPIC P
Projects
None yet
Milestone
1.0.0-rc.9
Development

Successfully merging a pull request may close this issue.

fix(ui5-li): visual alignment
2 participants
@ilhan007 @nnaydenow