Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-list): introduce role property #2235

Merged
merged 3 commits into from
Sep 28, 2020
Merged

feat(ui5-list): introduce role property #2235

merged 3 commits into from
Sep 28, 2020

Conversation

fifoosid
Copy link
Contributor

Part of #2231

@fifoosid fifoosid changed the title List role feat(ui5-list): introduce role property Sep 23, 2020
mastanshaikk
mastanshaikk reviewed Sep 25, 2020
View reviewed changes
Copy link

@mastanshaikk mastanshaikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fifoosid fifoosid merged commit d5a91e3 into master Sep 28, 2020
@fifoosid fifoosid deleted the list-role branch September 28, 2020 11:29
fifoosid added a commit that referenced this pull request Sep 28, 2020
@fifoosid
feat(ui5-list): introduce role property (#2235)
16bb4a0
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
@fifoosid @ilhan007
feat(ui5-list): introduce role property (#2235)
04978a7
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@fifoosid @ilhan007
feat(ui5-list): introduce role property (#2235)
e271813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastanshaikk mastanshaikk mastanshaikk left review comments

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
for review SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fifoosid @ilhan007 @mastanshaikk