Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][ui5-button][icon only button] set tooltip and aria-label to inner svg #2393

Closed
Hubery-Shen opened this issue Oct 23, 2020 · 2 comments · Fixed by #2492
Closed

Comments

@Hubery-Shen
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.

Component:
The component is ui5-button ( icon only button ), this icon i passed is : message-error icon

Feature request:

  1. I want to set the show-tooltip attribute's value by myself ( value: true / false )
  2. I want to custom the aria-label value for inner SVG
  3. I want to change the title inside the SVG

WX20201023-102944

@fifoosid
Copy link
Contributor

Hi @Hubery-Shen

I assume that you are using ui5-button with no text(icon only). This means that you need to set the aria-label and title properties to the ui5-button. Why do you need to set them to the inner SVG?

The same logic applies to the tooltip as well. If you set the tooltip to the icon, if you hover the button between the border and the icon, no tooltip will be shown. Do you need a tooltip for the whole button?

@Hubery-Shen
Copy link
Author

Hi @fifoosid

I assume that you are using ui5-button with no text(icon only). This means that you need to set the aria-label and title properties to the ui5-button. Why do you need to set them to the inner SVG?

I found that this issue has been resolved in 0.23.6

The same logic applies to the tooltip as well. If you set the tooltip to the icon, if you hover the button between the border and the icon, no tooltip will be shown. Do you need a tooltip for the whole button?

Yes, I need a tooltip for the whole button. I don't want to show the tooltip of icon

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants