Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Page component #2433

Closed
ilhan007 opened this issue Nov 4, 2020 · 1 comment · Fixed by #2685
Closed

Feature request: Page component #2433

ilhan007 opened this issue Nov 4, 2020 · 1 comment · Fixed by #2685
Assignees
@ivoplashkov
Labels
approved This issue is approved feature request High Prio Planned SAP SF TOPIC RL
Milestone
1.0.0-rc.12

Comments

@ilhan007
Copy link
Member

ilhan007 commented Nov 4, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
We need "page" component (ui5-page) as part of the "fiori" package, that follows the UX/VD of the sap.m.Page

Describe the solution you'd like
The component should take 100% height and should have the following features:

  • slots for header, content (should be put in the middle) and footer
  • property to make it scrollable or not scrollable, when the property is enabled, the header and footer should be visible while scrolling the content
  • property to support "floating footer"- the footer should not take space, but the page should add more padding to the scrolling content, so that when scrolling to the very bottom of the content the content does not underlay the footer.
  • the floating footer should show/hide with an animation
  • page's background should be customizable with standard CSS on tag level <ui5-page style="background: red"
  • As always - the required accessibility, RTL, theming, playground sample should be in place.
@ilhan007
Copy link
Member Author

ilhan007 commented Nov 4, 2020

Hello @SAP/ui5-webcomponents-topic-rl we would like to have new Page like component. The initial scope, based on the stakeholder requests #2407 is described in the current issue.
You can proceed with the planning, prototyping and execution works.

@ilhan007 ilhan007 added this to the 1.0.0-rc.11 milestone Nov 4, 2020
@ilhan007 ilhan007 mentioned this issue Nov 4, 2020
Closed
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.11, 1.0.0-rc.12 Dec 21, 2020
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.12, 1.0.0-rc.13 Jan 11, 2021
@ilhan007 ilhan007 added approved This issue is approved Planned labels Jan 11, 2021
@ivoplashkov ivoplashkov mentioned this issue Jan 14, 2021
Merged
ilhan007 pushed a commit that referenced this issue Jan 26, 2021
@ivoplashkov
feat(ui5-page): Initial implementation (#2685)
bd09e17 
The component has the following features:
- slots for header, content (should be put in the middle) and footer
- property to make it scrollable or not scrollable
- both the header and footer are visible while scrolling the content
- floatingFooter - property to support "floating footer"- the footer should not take space, but the page should add more padding to the scrolling content, so that when scrolling to the very bottom of the content the content does not underlay the footer.
- hideFooter

FIXES: #2433
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.13, 1.0.0-rc.12 Jan 26, 2021
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 1, 2021
@ivoplashkov @alexandar-mitsev
feat(ui5-page): Initial implementation (SAP#2685)
b08b551 
The component has the following features:
- slots for header, content (should be put in the middle) and footer
- property to make it scrollable or not scrollable
- both the header and footer are visible while scrolling the content
- floatingFooter - property to support "floating footer"- the footer should not take space, but the page should add more padding to the scrolling content, so that when scrolling to the very bottom of the content the content does not underlay the footer.
- hideFooter

FIXES: SAP#2433
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@ivoplashkov @NHristov-sap
feat(ui5-page): Initial implementation (SAP#2685)
873823f 
The component has the following features:
- slots for header, content (should be put in the middle) and footer
- property to make it scrollable or not scrollable
- both the header and footer are visible while scrolling the content
- floatingFooter - property to support "floating footer"- the footer should not take space, but the page should add more padding to the scrolling content, so that when scrolling to the very bottom of the content the content does not underlay the footer.
- hideFooter

FIXES: SAP#2433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivoplashkov ivoplashkov

Labels
approved This issue is approved feature request High Prio Planned SAP SF TOPIC RL
Projects
None yet
Milestone
1.0.0-rc.12
Development

Successfully merging a pull request may close this issue.

feat(ui5-page): Initial implementation SAP/ui5-webcomponents
2 participants
@ilhan007 @ivoplashkov