Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-wizard and ui5-button issues #2523

Closed
BodhiHu opened this issue Nov 27, 2020 · 8 comments · Fixed by #2547
Closed

ui-wizard and ui5-button issues #2523

BodhiHu opened this issue Nov 27, 2020 · 8 comments · Fixed by #2547
Assignees
@ilhan007
Labels
High Prio SAP SF TOPIC RL
Milestone
0.27.2

Comments

@BodhiHu
Copy link

BodhiHu commented Nov 27, 2020

Describe the bug

  1. The ui5-wizard component is behaving/looking different from sap.m.Wizard
  2. The ui5-button not showing some UI5 icons (like "share", ...etc)

To reproduce

Please see Screenshots

Isolated example
NA

Expected behavior

  1. The ui5-wizard component should behave/look the same as sap.m.Wizard
  2. The ui5-button should show all UI5 icons

Screenshots

Wizard content has extra 4rem bottom space and background color not set the same as sap m Wizard

Some UI5 icons not showing on ui5-button

On Mobile, Wizard nav header steps different from sap m Wizard (should be collapsed, and show step title)

Context

  • UI5 Web Components version: 0.23.6
  • OS/Platform: Mac
  • Browser (if relevant): Chrome
  • Other information: NA

Affected components (if known)
NA

Log output / Any errors in the console
NA

Organization: (if applicable)
SF

Priority: (optional) (Low, Medium, High or Very High)
Medium

Business impact: (mandatory for "Very High")
@BodhiHu
Copy link
Author

BodhiHu commented Nov 27, 2020 •
edited
Loading

Hi friends,
When developing with ui5-webcomponents, we found above issues,
can you please help take a look ?

Thank you & Best Regards

@ilhan007
Copy link
Member

ilhan007 commented Nov 30, 2020 •
edited
Loading

Hello @BodhiHu

  1. Showing or not showing icons in buttons or standalone has nothing to do with the Wizard itself.
    Check your imports and if everything is correct - create a another issue about the Button or Icon

  2. Wizard nav header header issue
    We agreed that the responsive behaviour will not be part of the initial delivery.
    It is currently developed -> ui5-wizard: responsive behavior #2441

@ilhan007
Copy link
Member

Hello @BodhiHu

I look at the issue with the padding, but could you provide url, steps, credentials, etc in order to reproduce it and investigate further.

@ilhan007 ilhan007 self-assigned this Nov 30, 2020
@BodhiHu
Copy link
Author

BodhiHu commented Nov 30, 2020

Hi @ilhan007 ,

  1. For the extra bottom padding issue, I have created a codesandbox, please have a look:
    https://codesandbox.io/s/ui5-webcomponents-playground-qgwcz

  2. For the icons issue, just noticed we need to import the referenced icons first to use them : D

Thank you

@ilhan007
Copy link
Member

ilhan007 commented Dec 4, 2020 •
edited
Loading

Hello @BodhiHu

I want to clarify sth about the background color.
Currently there is no background color set, I am about to use the sapBackgroundColor variable which results in #f7f7f7 in Quartz Light (sap_fiori_3) theme. This color will correspond to the openui5 Wizard's Standard bg-color, but it has also several additional options - List(#fff) and Solid (#edeff0). You expect to have darker background for the content from what I read, so is #f7f7f7 fine or?

@ilhan007 ilhan007 mentioned this issue Dec 4, 2020
Merged
@ilhan007
Copy link
Member

ilhan007 commented Dec 4, 2020

Hi @SAP/ui5-webcomponents-topic-rl there is a PR addressing author's feedback: #2547

ilhan007 added a commit that referenced this issue Dec 9, 2020
@ilhan007
fix(ui5-wizard): fix styling issues (#2547)
65cb42f 
- set default content background (equivalent to Standard in openui5)
- remove additional space from the content bottom

FIXES #2523
ilhan007 added a commit that referenced this issue Dec 9, 2020
@ilhan007
fix(ui5-wizard): fix styling issues (#2547)
7c45a0c 
- set default content background (equivalent to Standard in openui5)
- remove additional space from the content bottom

FIXES #2523
@ilhan007 ilhan007 added this to the 0.27.2 milestone Dec 9, 2020
@BodhiHu
Copy link
Author

BodhiHu commented Dec 11, 2020

Hi @ilhan007 , sorry for late response, from the fixing PR, I think setting the bg color to --sapBackgroundColor should be fine : D

@ilhan007
Copy link
Member

Hello @BodhiHu

we have just closed the following feature request, regarding the responsive behaviour of the Wizard nav header #2441

And It will be soon released released (1-2 weeks) in version 0.29.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
High Prio SAP SF TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Milestone
0.27.2
Development

Successfully merging a pull request may close this issue.

fix(ui5-wizard): fix styling issues SAP/ui5-webcomponents
2 participants
@BodhiHu @ilhan007