Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-date-picker: Incorrect accessible description #2604

Closed
elenastoyanovaa opened this issue Dec 21, 2020 · 0 comments · Fixed by #2628
Closed

ui5-date-picker: Incorrect accessible description #2604

elenastoyanovaa opened this issue Dec 21, 2020 · 0 comments · Fixed by #2628
Assignees
@unazko
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@elenastoyanovaa
Copy link
Contributor

elenastoyanovaa commented Dec 21, 2020 •
edited
Loading

Hello @SAP/ui5-webcomponents-topic-b ,

Could you please check this issue?

Describe the bug
The aria-describedby of the ui5-date-picker inner input points to a non-existing element. Currently it points to a ${this._id}-date, but there is no such element. Probably ${this._id}-desc is the correct one. (should point to the element with "Date" text). Add a test in order to prevent future similar issues.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/DatePicker/
  2. Inspect the inner input element.
  3. Copy the value of the aria-describedby and try to find the element with the corresponding ID.

Note: See the Accessibility Status Wiki of the Date Picker for more info and update the wiki, when the issue is resolved.

Affected components
ui5-date-picker
@elenastoyanovaa elenastoyanovaa added the bug This issue is a bug in the code label Dec 21, 2020
@unazko unazko self-assigned this Dec 31, 2020
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Jan 5, 2021
@unazko
fix(ui5-date-picker): input type is now conveyed
b3cd926 
The component input type is recognized by the
screen reader, with the help of 'aria-roledescription'
attribute.

Fixes SAP#2604
@unazko unazko mentioned this issue Jan 5, 2021
Merged
ilhan007 pushed a commit that referenced this issue Jan 28, 2021
@unazko
fix(ui5-date-picker): input type is now conveyed (#2628)
70e3269 
The component input type is recognised by the screen reader,
with the help of 'aria-roledescription' attribute.

Fixes #2604
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 1, 2021
@unazko @alexandar-mitsev
fix(ui5-date-picker): input type is now conveyed (SAP#2628)
0d1c37e 
The component input type is recognised by the screen reader,
with the help of 'aria-roledescription' attribute.

Fixes SAP#2604
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@unazko @NHristov-sap
fix(ui5-date-picker): input type is now conveyed (SAP#2628)
b21528b 
The component input type is recognised by the screen reader,
with the help of 'aria-roledescription' attribute.

Fixes SAP#2604
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-date-picker): input type is now conveyed unazko/ui5-webcomponents
2 participants
@elenastoyanovaa @unazko