-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui5-responsive-popover: error on opening #2717
Comments
Hello @ui5-webcomponents-topic-p I am forwarding this issue to you, because the "isForwardElement" methodof the List is not working properly in some cases. Best regards, |
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue. FIXES: #2717
hello colleagues, thank you for the quick fix on this issue! Is there any ETA on when it will be released? This is currently blocking our production release in our app |
Hello @stevetsanders can you share more details about your app and release plan? The next RC will be released on 11 Feb. But, there is an option to provide you a "master" version, that includes the very latest development. The version would look like 0.0.0-commit_id and can be installed with the "next" tag npm install @ui5/webcomponents@next |
Hi @ilhan007 , Actually I spoke wrongly. It doesn't impact our production release, but we did want to update our libraries with a couple of new features available. Thanks a lot for the info, I'll try to install the version for the specific commit and see if it works out. UPDATE: I guess the next version is not yet updated for the latest commit. Is this something you must trigger manually? |
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue. FIXES: SAP#2717
hi @ilhan007 , any chance you could provide another 'next' version so we could try it out? |
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue. FIXES: SAP#2717
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue. FIXES: SAP#2717
Describe the bug
When I try to open a
ui5-responsive-popover
with twoui5-list
as children, I get the following error:To reproduce
Steps to reproduce the behavior:
Isolated example
https://codesandbox.io/s/late-cookies-gdgj4?file=/src/App.js
Expected behavior
I would expect that the popover opens without an error
Screenshots
If applicable, add screenshots to help explain your problem.
Context
Affected components
Log output / Any errors in the console
cc @stevetsanders
The text was updated successfully, but these errors were encountered: