Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-responsive-popover: error on opening #2717

Closed
MarcusNotheis opened this issue Jan 21, 2021 · 5 comments · Fixed by #2720
Closed

ui5-responsive-popover: error on opening #2717

MarcusNotheis opened this issue Jan 21, 2021 · 5 comments · Fixed by #2720
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@MarcusNotheis
Copy link
Collaborator

Describe the bug
When I try to open a ui5-responsive-popover with two ui5-list as children, I get the following error:

List.js:595 Uncaught TypeError: Cannot read property 'id' of null
    at HTMLElement.isForwardElement (List.js:595)
    at HTMLElement._onfocusin (List.js:561)
    at EventPart.handleEvent (parts.ts:512)
    at HTMLDivElement.EventPart.__boundHandleEvent (parts.ts:470)
    at HTMLElement.applyFocus (Popup.js:290)
    at async HTMLElement.applyInitialFocus (Popup.js:274)

To reproduce
Steps to reproduce the behavior:

  1. open the playground: https://codesandbox.io/s/late-cookies-gdgj4?file=/src/App.js
  2. Click on "Open Popover"
  3. See the error

Isolated example
https://codesandbox.io/s/late-cookies-gdgj4?file=/src/App.js

Expected behavior
I would expect that the popover opens without an error

Screenshots
If applicable, add screenshots to help explain your problem.

Context

  • UI5 Web Components version: 1.0.0-rc.11
  • OS/Platform: macOS
  • Browser: Chrome

Affected components

  • ui5-responsive-popover
  • ui5-list

Log output / Any errors in the console

List.js:595 Uncaught TypeError: Cannot read property 'id' of null
    at HTMLElement.isForwardElement (List.js:595)
    at HTMLElement._onfocusin (List.js:561)
    at EventPart.handleEvent (parts.ts:512)
    at HTMLDivElement.EventPart.__boundHandleEvent (parts.ts:470)
    at HTMLElement.applyFocus (Popup.js:290)
    at async HTMLElement.applyInitialFocus (Popup.js:274)

cc @stevetsanders

@Martotko Martotko self-assigned this Jan 21, 2021
@Martotko Martotko added bug This issue is a bug in the code Medium Prio TOPIC P labels Jan 21, 2021
@Martotko
Copy link
Contributor

Hello @ui5-webcomponents-topic-p I am forwarding this issue to you, because the "isForwardElement" methodof the List is not working properly in some cases.

Best regards,
Martin

@Martotko Martotko removed their assignment Jan 21, 2021
@ilhan007 ilhan007 self-assigned this Jan 21, 2021
ilhan007 added a commit that referenced this issue Jan 22, 2021
ilhan007 added a commit that referenced this issue Jan 22, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: #2717
@stevetsanders
Copy link

hello colleagues, thank you for the quick fix on this issue! Is there any ETA on when it will be released? This is currently blocking our production release in our app

@ilhan007
Copy link
Member

Hello @stevetsanders can you share more details about your app and release plan?
Our release plan can be seen here https://github.com/SAP/ui5-webcomponents/projects

The next RC will be released on 11 Feb. But, there is an option to provide you a "master" version, that includes the very latest development. The version would look like 0.0.0-commit_id and can be installed with the "next" tag

npm install @ui5/webcomponents@next

Screenshot 2021-01-22 at 9 26 02 PM

@stevetsanders
Copy link

stevetsanders commented Jan 22, 2021

Hi @ilhan007 , Actually I spoke wrongly. It doesn't impact our production release, but we did want to update our libraries with a couple of new features available.

Thanks a lot for the info, I'll try to install the version for the specific commit and see if it works out.

UPDATE: I guess the next version is not yet updated for the latest commit. Is this something you must trigger manually?

kineticjs pushed a commit to kineticjs/ui5-webcomponents that referenced this issue Jan 25, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
@stevetsanders
Copy link

hi @ilhan007 , any chance you could provide another 'next' version so we could try it out?

alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 1, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants