Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-list): fix JS error on focusin #2720

Merged
merged 1 commit into from
Jan 22, 2021
Merged

fix(ui5-list): fix JS error on focusin #2720

merged 1 commit into from
Jan 22, 2021

Conversation

ilhan007
Copy link
Member

Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: #2717

@ilhan007 ilhan007 requested a review from nnaydenow January 22, 2021 09:16
@ilhan007 ilhan007 merged commit b36e54e into master Jan 22, 2021
@ilhan007 ilhan007 deleted the fix-list-focusin branch January 22, 2021 12:07
kineticjs pushed a commit to kineticjs/ui5-webcomponents that referenced this pull request Jan 25, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this pull request Feb 1, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this pull request Feb 9, 2021
Fixe a JS error that used to thrown upon "focusin" when non-existing DOM elements have been accessed. Those DOM elements are not rendered when there are no list items, which is the example in the referenced issue.

FIXES: SAP#2717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-responsive-popover: error on opening
2 participants