Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rounded corners in <ui5-popover> #30

Closed
pavelkornev opened this issue Feb 12, 2019 · 3 comments
Closed

Missing rounded corners in <ui5-popover> #30

pavelkornev opened this issue Feb 12, 2019 · 3 comments
Assignees
Labels
bug This issue is a bug in the code

Comments

@pavelkornev
Copy link
Member

Describe the bug
On https://sap.github.io/ui5-webcomponents/playground.html#/components/Popover
When opening the popover, the top corners are rounded and the bottom not:
ui5 web components - playground 2019-02-12 22-12-35

I assume it might be a design decision to round only top corners, but it doesn't look so because in such scenarios the contrast is normally higher (e.g. 3-5 time bigger border-radius, example — https://i.stack.imgur.com/srHXl.png).

Expected behavior
all 4 corners should be rounded or not, or have an explicit contrast.

@pavelkornev pavelkornev added the bug This issue is a bug in the code label Feb 12, 2019
@pavelkornev
Copy link
Member Author

And there is also the accessibility issue in this example (click on label doesn't bring focus on the field):
screencast 2019-02-12 22-24-21

@ilhan007
Copy link
Member

Hello @pavelkornev.

The accessibility issue is addressed with
#33

And, regarding the rounding of the popover corners, we will raise the question to the designers and get back to you.

@ilhan007
Copy link
Member

Hello @pavelkornev, we rounded the bottom borders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants