Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-conflict events should not dispatch the original event #304

Closed
pskelin opened this issue Apr 5, 2019 · 0 comments · Fixed by #363
Closed

no-conflict events should not dispatch the original event #304

pskelin opened this issue Apr 5, 2019 · 0 comments · Fixed by #363
Assignees
@MapTo0
Labels
bug This issue is a bug in the code

Comments

@pskelin
Copy link
Contributor

pskelin commented Apr 5, 2019

Describe the bug
When using no-conflict for the press event, a ui5-press event is dispatched as expected, but the press event is also dispatched.

Expected behavior
If I provide a no-conflict for an event, the assumption is that there is other framework or future browser functionality that provides some functionality with the original event name (example: hammer js fires a press). If the app has a press handler for the hammerjs usage, getting an event from the ui5 webcomponent is wrong.

additional difficulties
The original event names are used in the templates, and the event names are decided at build time. This means all components using events of other components they embed should also use the no-conflict event name as the orignal one will stop being fired.
@pskelin pskelin added the bug This issue is a bug in the code label Apr 5, 2019
MapTo0 added a commit that referenced this issue Apr 24, 2019
@MapTo0
fix: prevent dual event dispatching in no conflict mode
3c35a58 
- all controls should now listen for prefixed events ui5-*
- both events are now dispatched in normal mode
- in no conflict mode - just the prefixed event is dispatched

Fixes: #304
@MapTo0 MapTo0 mentioned this issue Apr 24, 2019
Merged
@MapTo0 MapTo0 self-assigned this May 14, 2019
MapTo0 added a commit that referenced this issue May 15, 2019
@MapTo0
fix: prevent dual event dispatching in no conflict mode (#363)
4cbe3de 
- all controls should now listen for prefixed events ui5-*
- all test run with no conflict setting, therefore test pages should interact with ui5-* events
- both events are now dispatched in normal mode
- in no conflict mode - just the prefixed event is dispatched

Fixes: #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MapTo0 MapTo0

Labels
bug This issue is a bug in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent dual event dispatching in no conflict mode SAP/ui5-webcomponents
2 participants
@MapTo0 @pskelin