-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-step-input): firing step input once when value is deleted #3474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix breaks the following case:
Enter 0 as value
Focus out the step input(event is thrown)
Delete the value
Focus out
Value is now empty string (should be 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround for the previous comment and the following case is not handled:
Start with Stepinput with some value(for example: 5)
Mark the value & delete it
Focus out
The value 0 is restored(The value 5 should be restored).
The current behaviour is when you have any value and you delete it( the state is empty string), then you focus out, you have 0 as value. |
fixes: #3457