Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-step-input): firing step input once when value is deleted #3474

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #3457

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix breaks the following case:
Enter 0 as value
Focus out the step input(event is thrown)
Delete the value
Focus out
Value is now empty string (should be 0)

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround for the previous comment and the following case is not handled:

Start with Stepinput with some value(for example: 5)
Mark the value & delete it
Focus out
The value 0 is restored(The value 5 should be restored).

@tsanislavgatev tsanislavgatev requested a review from fifoosid June 29, 2021 06:54
@tsanislavgatev
Copy link
Contributor Author

This is a workaround for the previous comment and the following case is not handled:

Start with Stepinput with some value(for example: 5)
Mark the value & delete it
Focus out
The value 0 is restored(The value 5 should be restored).

The current behaviour is when you have any value and you delete it( the state is empty string), then you focus out, you have 0 as value.

@tsanislavgatev tsanislavgatev merged commit a5f27f2 into master Jul 1, 2021
@tsanislavgatev tsanislavgatev deleted the step-input-change-fire-fix branch July 1, 2021 08:11
@ilhan007 ilhan007 added the SAP SF label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-step-input fires 2 change events when 0 is cleared
3 participants