Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent dual event dispatching in no conflict mode #363

Merged
merged 4 commits into from
May 15, 2019
Merged

fix: prevent dual event dispatching in no conflict mode #363

merged 4 commits into from
May 15, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 24, 2019 •
edited
Loading

  • all controls should now listen for prefixed events ui5-*
  • all test run with no conflict setting, therefore test pages should interact with ui5-* events
  • both events are now dispatched in normal mode
  • in no conflict mode - just the prefixed event is dispatched

Fixes: #304

@MapTo0
fix: prevent dual event dispatching in no conflict mode
3c35a58 
- all controls should now listen for prefixed events ui5-*
- both events are now dispatched in normal mode
- in no conflict mode - just the prefixed event is dispatched

Fixes: #304
@MapTo0 MapTo0 requested review from pskelin and vladitasev April 24, 2019 13:05
pskelin
pskelin requested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@pskelin pskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also run the tests in no-conflict mode to make sure we don't forget to use the internal events

packages/base/src/UI5Element.js Outdated Show resolved Hide resolved
@MapTo0 MapTo0 merged commit 4cbe3de into master May 15, 2019
@pskelin pskelin deleted the no-conflict branch May 16, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-conflict events should not dispatch the original event
2 participants
@MapTo0 @pskelin