Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][UI5-Popover][BUG][Urgent][0.31.19] accessibleName doesn't work #4005

Closed
sfsf-xweb-sh opened this issue Sep 27, 2021 · 5 comments
Closed

Comments

@sfsf-xweb-sh
Copy link

sfsf-xweb-sh commented Sep 27, 2021

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.
we use NVDA to test a11y issues in our project

The version of ui5-webcomponent is 0.31.19

Reproduce Step:

  1. open https://github.wdf.sap.corp/pages/xweb/common-react/?path=/story/react-components-first-time-guidance--default
  2. click "show the first normal slide"
  3. click the "start tour" button

Screen Shot 2021-09-27 at 2 21 44 PM
Screen Shot 2021-09-27 at 5 00 17 PM

We can see that:

The accessiblename is "test accessibleName attribute for popover", but this text is not announced by screen reader

  • Organization: SF
@Todor-ads Todor-ads self-assigned this Sep 27, 2021
@Todor-ads Todor-ads added the ACC label Sep 27, 2021
@Todor-ads Todor-ads added bug This issue is a bug in the code High Prio TOPIC RD labels Sep 27, 2021
@Todor-ads
Copy link
Member

Hi @SAP/ui5-webcomponents-topic-rd,

The Popover component is part of your topic.

Best regards,
Todor

@Todor-ads Todor-ads removed their assignment Sep 27, 2021
@dimovpetar dimovpetar self-assigned this Sep 28, 2021
@dimovpetar
Copy link
Contributor

Hello @sfsf-xweb-sh ,

In release 0.31 the property is called ariaLabel. It has been renamed to accessibleName in the newer versions with #3449. Please use the ariaLabel (aria-label as attribute) in your case instead.

Best regards,
Petar

@dimovpetar dimovpetar added consulting and removed bug This issue is a bug in the code labels Sep 28, 2021
@ilhan007
Copy link
Member

ilhan007 commented Oct 3, 2021

Hello @sfsf-xweb-sh
we introduced accessibleName for the Popover component
and it will be available with 0.31.20.

I am keeping the issue open, so you can close the issue yourself after trying it out.

@ilhan007 ilhan007 reopened this Oct 3, 2021
@ilhan007
Copy link
Member

ilhan007 commented Oct 4, 2021

Hello @sfsf-xweb-sh the 0.31.20 is released and accessibleName has been added to the Popover.

@sfsf-xweb-sh
Copy link
Author

@ilhan007 ok, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

5 participants