feat: rename aria-label to accessible-name #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
changed the title
elenastoyanovaa
requested changes
Jun 23, 2021
There was a problem hiding this comment.
Could you change the jsdoc of the accessible name for all components with something like the description for the panel https://sap.github.io/ui5-webcomponents/master/playground/components/Panel/ ?
ilhan007
previously approved these changes
Jun 28, 2021
elenastoyanovaa
requested changes
Jul 9, 2021
| @@ -2,8 +2,8 @@ import findNodeOwner from "./findNodeOwner.js"; | |||
|
|
|||
| const getEffectiveAriaLabelText = el => { | |||
| if (!el.ariaLabelledby) { | |||
There was a problem hiding this comment.
is this line needed?
There was a problem hiding this comment.
Yes, it is. Based on this check, getAriaLabelledByTexts(line 12) is called.
ilhan007
approved these changes
Jul 19, 2021
elenastoyanovaa
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3107
BREAKING_CHANGE:
ariaLabellproperty is renamed toaccessible-namefor the following components: