-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-card): header slot is added #3490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all uses of <ui5-card>
in the test pages.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The card markup needs to be fixed in -
http://localhost:8081/test-resources/pages/Timeline.html
http://localhost:8080/test-resources/pages/Carousel.html
http://localhost:8080/test-resources/pages/Components.html
http://localhost:8080/test-resources/pages/Kitchen.html
http://localhost:8080/test-resources/pages/Kitchen.openui5.html
Add mention of ui5-card-header
in docs/Public Module Imports.md
and package/main/README.md
All the indentations in the files you've edited have been converted to spaces. So you need to format them back to tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, there are some inline comments, that you can find.
5197747
to
6f6df66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing, that I noticed, not sure if we need to address it.
If a header slot is used with a custom header, not the CardHeader, the separator line between the header and content parts is not displayed (probably it's part of the CardHeader).
Did you already discuss this internally? Should we draw this line, or let the application developers add it to the custom header (which might be not so convenient as they should now the CSS param for the color of the line)? I will accept any decision from your side.
We have discuss it and we will add(Card component) the separator line. |
0e047ba
to
0ef4db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides header separator LGTM
please retest, the saparator is there
Part of #3107 |
BREAKING CHANGE: titleText, subtitleText, status, headerInteractive properties, action and avatar slot and header-click event are move to component, and the card now has a header slot, instead of all the properties.