Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShellbarItem Popover position wrong #419

Closed
d3nergy opened this issue May 21, 2019 · 0 comments · Fixed by #421
Closed

ShellbarItem Popover position wrong #419

d3nergy opened this issue May 21, 2019 · 0 comments · Fixed by #421
Assignees
@MapTo0
Labels
approved This issue is approved bug This issue is a bug in the code enhancement New feature or request

Comments

@d3nergy
Copy link

d3nergy commented May 21, 2019

Describe the bug
when using a ShellbarItem as a child of the Shellbar and defining the ref to open a popover onPress the popover is not opening underneth the ShellbarItem but on the top left corner of the page.

To reproduce
Steps to reproduce the behavior:
Use a ShellbarItem , define Popover with ref , open on Press ( ....openBy(event.getHtmlSourceElement())

Expected behavior
Open directly where the item is just like notifications or profile Popover

Affected components (if known)
ShellbarItem

I would suggest to provide a 'targetRef' parameter just like the notifications or profile or...
@MapTo0 MapTo0 self-assigned this May 21, 2019
@MapTo0 MapTo0 added approved This issue is approved bug This issue is a bug in the code enhancement New feature or request labels May 21, 2019
MapTo0 added a commit that referenced this issue May 21, 2019
@MapTo0
feat(ui5-shellbar): API improvements
366ccf5 
- adds a targetRef parameter to press event of shellbar-item
- adds a support for preventDefault() of press event of shellbar-item
- provides a public method #closeOverflow to the shellbar component

FIXES: #419
@MapTo0 MapTo0 mentioned this issue May 21, 2019
Merged
MapTo0 added a commit that referenced this issue May 22, 2019
@MapTo0
feat(ui5-shellbar): API improvements (#421)
e0ff36d 
* feat(ui5-shellbar): API improvements

- adds a targetRef parameter to press event of shellbar-item
- adds a support for preventDefault() of press event of shellbar-item
- provides a public method #closeOverflow to the shellbar component

FIXES: #419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MapTo0 MapTo0

Labels
approved This issue is approved bug This issue is a bug in the code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-shellbar): API improvements SAP/ui5-webcomponents
2 participants
@MapTo0 @d3nergy