Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stretched ui5-dialog: issue found from mobile exploratory testing on Android #4254

Closed
1 of 4 tasks
dimovpetar opened this issue Nov 3, 2021 · 0 comments · Fixed by #4327
Closed
1 of 4 tasks

Stretched ui5-dialog: issue found from mobile exploratory testing on Android #4254

dimovpetar opened this issue Nov 3, 2021 · 0 comments · Fixed by #4327
Assignees
@dimovpetar
Labels
1.0 Release Testing bug This issue is a bug in the code Low Prio TOPIC RD

Comments

@dimovpetar
Copy link
Contributor

dimovpetar commented Nov 3, 2021 •
edited
Loading

Bug Description

Corners of the dialog are rounded on Android devices.

Steps to Reproduce

  1. Open any stretched dialog
  2. Observe the corners

Context

  • UI5 Web Components version: master
  • OS/Platform: Android
  • Browser: Chrome
  • Affected component: ui5-dialog

Log Output / Stack Trace / Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@dimovpetar dimovpetar added 1.0 Release Testing bug This issue is a bug in the code labels Nov 8, 2021
@dimovpetar dimovpetar self-assigned this Nov 12, 2021
dimovpetar added a commit that referenced this issue Nov 12, 2021
@dimovpetar
fix(ui5-dialog): correct border radius when stretched on phones
1c2edb2 
Fixes: #4254
@dimovpetar dimovpetar mentioned this issue Nov 12, 2021
Merged
dimovpetar added a commit that referenced this issue Nov 22, 2021
@dimovpetar
fix(ui5-dialog): correct border radius when stretched on phones (#4327)
5aedc43 
Fixes: #4254
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this issue Dec 13, 2021
@dimovpetar @ndeshev
fix(ui5-dialog): correct border radius when stretched on phones (SAP#…
7fa7d47 
…4327)

Fixes: SAP#4254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimovpetar dimovpetar

Labels
1.0 Release Testing bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-dialog): correct border radius when stretched on phones SAP/ui5-webcomponents
1 participant
@dimovpetar