Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][A11Y][Input]: valueStateMessage display incorrectly in RTL #4363

Closed
sfsf-xweb-sh opened this issue Nov 19, 2021 · 3 comments
Closed

[SF][A11Y][Input]: valueStateMessage display incorrectly in RTL #4363

sfsf-xweb-sh opened this issue Nov 19, 2021 · 3 comments
Assignees
@d3xter666
Labels
ACC bug This issue is a bug in the code Medium Prio SAP SF SF_ACC TOPIC RL

Comments

@sfsf-xweb-sh
Copy link

sfsf-xweb-sh commented Nov 19, 2021 •
edited
Loading

Hi Colleague,

When using required Input withe value state message "This field is required", we found that message always show in the left. This message should be displayed in the right when set sap-ui-rtl=true. Please take a look.
Thanks a lot.

Screenshots
When set sap-ui-rtl=false, it looks good.

Screen Shot 2021-11-19 at 9 21 25 AM

While set sap-ui-rtl=true, valueStateMessage still stay in left:

Screen Shot 2021-11-19 at 10 01 19 AM

UI5 Web Components for React Information
@ui5/webcomponents version: 0.31.22
@ui5/webcomponents-react version: 0.131.23
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Nov 19, 2021
@ndeshev ndeshev assigned ndeshev and unassigned ndeshev Nov 19, 2021
@IlianaB IlianaB self-assigned this Nov 19, 2021
@IlianaB IlianaB added bug This issue is a bug in the code SAP SF TOPIC RL ACC labels Nov 19, 2021
@IlianaB
Copy link
Member

IlianaB commented Nov 19, 2021

Hello @SAP/ui5-webcomponents-topic-rl I am forwarding this issue to you, because valueStateMessage for Input is displayed incorrectly in RTL mode: https://sap.github.io/ui5-webcomponents/playground/components/Input/?sap-ui-theme=sap_fiori_3&isrtl=true

Regards,
Iliana

@IlianaB IlianaB removed their assignment Nov 19, 2021
@d3xter666 d3xter666 self-assigned this Nov 23, 2021
@d3xter666
Copy link
Contributor

Hello,

The issue is fixed in the master branch with the following change: ce0dcd2

Would cherry-pick it for 0.31.*

Cheers

d3xter666 pushed a commit that referenced this issue Nov 23, 2021
@stbodurov @d3xter666
fix(ui5-input, ui5-multi-combobox): value state popup now aligned pro…
6c3a09f 
…perly in RTL mode (#4310)

Fixes #4363
@d3xter666 d3xter666 mentioned this issue Nov 23, 2021
Merged
d3xter666 added a commit that referenced this issue Nov 25, 2021
@d3xter666 @stbodurov
fix(ui5-input, ui5-multi-combobox): value state popup now aligned pro…
a855dcc 
…perly in RTL mode (#4310) (#4382)

Fixes #4363

Co-authored-by: Stanislav Bodurov <stbodurov@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d3xter666 d3xter666

Labels
ACC bug This issue is a bug in the code Medium Prio SAP SF SF_ACC TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ndeshev @d3xter666 @MarcusNotheis @IlianaB @nikolay-kolarov @sfsf-xweb-sh