Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][1.0.2][ui5-popover][BUG][Expected within two weeks] Popover border is overlapped with screen left edge #4598

Closed
sfsf-xweb-sh opened this issue Jan 20, 2022 · 1 comment
Assignees

Comments

@sfsf-xweb-sh
Copy link

Dear UI5 team,

This is SuccessFactors Web Experience Shanghai team. We found this issue in the process of upgrading to the latest version of ui5-webcomponent, and it can be reproduced on mobile web.
The version of ui5-webcomponent is 1.0.2

Bug Description

Popover is not aligned in page center (mobile web) and its left border is overlapped with screen edge.

Expected Behavior

Popover should be aligned in page center and have some space against screen edge.

Steps to Reproduce

  1. Open below link in mobile browser, log in with cgrant/pwd
    https://qacand.hcm.ondemand.com/sf/goals?bplte_company=TALH2TGMM1&mock&sap-ui-theme=sap_horizon#/goal-list

  2. There would be a popup opened automatically. Click "Start Tour"

  3. Then you can see popover's left border is overlapped with screen left edge. Please see below screenshot:
    Image from iOS (1)

@a-z-ivanov
Copy link
Contributor

Hello, @sfsf-xweb-sh,

I think it's because of your css styles. This classes .sf_common_comp-FirstTimeGuidance__Popover, :host(.sf_common_comp-FirstTimeGuidance__Popover.phone) define and redefine the min-width css property for the whole popover element. I think you should also redefine the max-width to override this rule
calc(100% - var(--_ui5_popup_viewport_margin)*2)
this is what makes it wider.

Regards,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants