Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][1.0.2][ui5-popover][BUG][Expected within two weeks] Popover arrow is detached from its body #4581

Closed
1 task done
sfsf-xweb-sh opened this issue Jan 14, 2022 · 5 comments
Closed
1 task done

[SF][1.0.2][ui5-popover][BUG][Expected within two weeks] Popover arrow is detached from its body #4581

sfsf-xweb-sh opened this issue Jan 14, 2022 · 5 comments
Assignees
@georgimkv
Labels
bug This issue is a bug in the code High Prio TOPIC RD

Comments

@sfsf-xweb-sh
Copy link

Dear UI5 team,

This is SuccessFactors Web Experience Shanghai team. We found this issue in the process of upgrading to the latest version of ui5-webcomponent, and it can be reproduced on mobile web.
The version of ui5-webcomponent is 1.0.2

Bug Description

Popover's arrow and body got detached.

Steps to Reproduce

  1. Open below link in mobile browser, log in with cgrant/pwd
    https://qacand.hcm.ondemand.com/sf/goals?bplte_company=TALH2TGMM1&mock&sap-ui-theme=sap_horizon#/goal-list

  2. There would be a popup opened automatically. Click "Start Tour"

  3. Then click "Next" button until it comes to the step indicated in below screenshot. Then you can see there is a styling issue in popover arrow.
    Image from iOS

Expected Behavior

Popover arrow and body should display normally.

Priority

  • Medium
@nnaydenow nnaydenow self-assigned this Jan 14, 2022
@nnaydenow
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-rd,

Issue is also observed in some "edge case" without sap_horizon theme. It is observed in following case where the popover opener is placed at the end of the screen. I prepared code snippix with fiori 3 theme but the issue is not that visible:
https://codesandbox.io/s/ui5-webcomponents-forked-o0w3e?file=/index.html

Could you please check this?

Regards,
Nayden

@nnaydenow nnaydenow added bug This issue is a bug in the code High Prio TOPIC RD labels Jan 14, 2022
@nnaydenow nnaydenow removed their assignment Jan 14, 2022
@georgimkv georgimkv self-assigned this Jan 17, 2022
@sfsf-xweb-sh
Copy link
Author

Hi @gmkv
We also found another UI issue on the same component, same steps to reproduce. After clicking "Start Tour", the popover shows up and it's not aligned in center of the mobile page(left border is overlapping with screen edge). Please see below screenshot.

If you feel this should be in another issue, please let me know, and I'll raise a new one.
mobile issue 2

@georgimkv
Copy link
Contributor

Hi @sfsf-xweb-sh
Yes, this looks like a unrelated thing. Please open a seperate issue for it.

@sfsf-xweb-sh
Copy link
Author

@gmkv #4598

georgimkv added a commit that referenced this issue Jan 20, 2022
@georgimkv
fix(ui5-popover): fixed arrow going out of bounds
03e87c4 
Part of #4581

The arrow of the Popover is now restricted within a range along each
dimension.  The border-radius of the Popover in the different themes is
considered.

This solves the issue where the Popover may be opened by a
small element placed at the corners of the viewport.
@georgimkv georgimkv mentioned this issue Jan 20, 2022
Merged
ilhan007 pushed a commit that referenced this issue Jan 21, 2022
@georgimkv
fix(ui5-popover): restrict arrow going out of bounds (#4599)
41239a8 
Part of #4581

The arrow of the Popover is now restricted within a range along each
dimension.  The border-radius of the Popover in the different themes is
considered.

This solves the issue where the Popover may be opened by a
small element placed at the corners of the viewport.
@ilhan007
Copy link
Member

Hello @sfsf-xweb-sh the issue is resolved and will be available with 1.1.0 end of the day.

@dobrinyonkov dobrinyonkov mentioned this issue Feb 23, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
bug This issue is a bug in the code High Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ilhan007 @georgimkv @nnaydenow @sfsf-xweb-sh